Skip to content

build(deps): bump headerkit to ==0.49.4 and release v4.0.4 - #84

Merged
elijahr merged 1 commit into
masterfrom
build/bump-headerkit-0.49.4
Oct 31, 2026
Merged

elijahr merged 1 commit into
masterfrom
build/bump-headerkit-0.49.4

Conversation

@elijahr

@elijahr elijahr commented Oct 31, 2026

Copy link
Copy Markdown
Owner

Bumps headerkit and headerkit[treesitter] dependencies to ==0.49.4 in pyproject.toml and uv.lock, and prepares the v4.0.4 release.

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

✅ Momus review posted — verdict APPROVE, 1 finding

████████████████████ 100%

run log

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR bumps headerkit from ==0.48.1 to ==0.49.4 and cuts v4.0.4. The diff is clean: version strings, lock file hashes, and CHANGELOG entries. However, no snapshot fixture (.expected.pxd) files are updated, while the [4.0.3] CHANGELOG documents that fixture updates were required for the prior headerkit bump. Tests use exact string comparison; if headerkit output changed, tests will break silently.

Severity tally: 1 Low.

Low

  • BOT-A1 (pyproject.toml:34): headerkit bump from 0.48.1 to 0.49.4 without corresponding snapshot fixture updates

Verdict: APPROVE.

Commands
  • Comment /ai-review or mention @axiomantic-momus[bot] to request a re-review of the latest changes.
  • Reply to a finding with won't fix, by design, or not a bug to decline it.
  • Reply with instead, ... to propose an alternative fix.

Cost: $0.04 - 49,713 in / 17,842 out tokens - deepseek/deepseek-v4-pro

Powered by Momus running deepseek/deepseek-v4-pro via openrouter.ai.

Comment thread pyproject.toml
dependencies = [
"Click",
"headerkit==0.48.1",
"headerkit==0.49.4",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BOT-A1 — Low (tests)
headerkit bump from 0.48.1 to 0.49.4 without corresponding snapshot fixture updates
The PR bumps headerkit from ==0.48.1 to ==0.49.4 (pyproject.toml line 34: '"headerkit==0.49.4"') but no .expected.pxd snapshot fixtures are updated. The [4.0.3] CHANGELOG entry documents that three fixtures—zlib.expected.pxd, jansson.expected.pxd, json_lib.expected.pxd—needed updating for the 0.48.1 bump. Tests use exact string comparison (e.g., test/assertions.py line 125: 'assert actual == expected'). If headerkit 0.49.4 changed any pxd output formatting, the test suite will fail. Without running tests, this cannot be verified, but the precedent from 4.0.3 makes it a real concern that needs investigation.

@elijahr
elijahr merged commit d2c98da into master Oct 31, 2026
18 checks passed
@elijahr
elijahr deleted the build/bump-headerkit-0.49.4 branch October 31, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant