Repository navigation
build(deps): bump headerkit to ==0.49.4 and release v4.0.4 - #84
Conversation
|
✅ Momus review posted — verdict APPROVE, 1 finding
|
There was a problem hiding this comment.
This PR bumps headerkit from ==0.48.1 to ==0.49.4 and cuts v4.0.4. The diff is clean: version strings, lock file hashes, and CHANGELOG entries. However, no snapshot fixture (.expected.pxd) files are updated, while the [4.0.3] CHANGELOG documents that fixture updates were required for the prior headerkit bump. Tests use exact string comparison; if headerkit output changed, tests will break silently.
Severity tally: 1 Low.
Low
- BOT-A1 (
pyproject.toml:34): headerkit bump from 0.48.1 to 0.49.4 without corresponding snapshot fixture updates
Verdict: APPROVE.
Commands
- Comment
/ai-reviewor mention @axiomantic-momus[bot] to request a re-review of the latest changes. - Reply to a finding with
won't fix,by design, ornot a bugto decline it. - Reply with
instead, ...to propose an alternative fix.
Cost: $0.04 - 49,713 in / 17,842 out tokens - deepseek/deepseek-v4-pro
Powered by Momus running deepseek/deepseek-v4-pro via openrouter.ai.
| dependencies = [ | ||
| "Click", | ||
| "headerkit==0.48.1", | ||
| "headerkit==0.49.4", |
There was a problem hiding this comment.
BOT-A1 — Low (tests)
headerkit bump from 0.48.1 to 0.49.4 without corresponding snapshot fixture updates
The PR bumps headerkit from ==0.48.1 to ==0.49.4 (pyproject.toml line 34: '"headerkit==0.49.4"') but no .expected.pxd snapshot fixtures are updated. The [4.0.3] CHANGELOG entry documents that three fixtures—zlib.expected.pxd, jansson.expected.pxd, json_lib.expected.pxd—needed updating for the 0.48.1 bump. Tests use exact string comparison (e.g., test/assertions.py line 125: 'assert actual == expected'). If headerkit 0.49.4 changed any pxd output formatting, the test suite will fail. Without running tests, this cannot be verified, but the precedent from 4.0.3 makes it a real concern that needs investigation.
Bumps
headerkitandheaderkit[treesitter]dependencies to==0.49.4inpyproject.tomlanduv.lock, and prepares thev4.0.4release.