Repository navigation
Conversation
This changes the MDEx integration from being a converter to being its own extension. The main goal of this is to make mdex an optional dependency for Tableau, so a Tableau release is not required when mdex updates or makes breaking changes. - Adds a `convert` callback to `Tableau.Extension` - Adds a `Tableau.Converter.convert` function for extensions to use - Post and Page extensions now will copy all files in the respective directory, and will convert them if there is a matching converter for that extension. Frontmatter is still required. - MDex and converter options are now set by their extension module instead of the `:config` key. - The contract for `Tableau.Converter.convert` now just takes content and opts. - `Tableau.Converter` is no longer a behaviour. - Converters now are extensions that implement the `convert` callback. - `Tableau.markdown` is removed. Use `Tableau.Converter` instead.
Collaborator
Author
|
@halostatue thank you for your earlier updates to mdex, but I've decided to decouple tableau from mdex a bit more. If you get some time, could you try out this branch? I believe I've called out all the important breaking changes, but I should probably also put in some migration tips "change this to this" etc. edit: you might also have to install the tableau_dev_server package from github as i havent published that yet i dont think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the MDEx integration from being a converter to being its
own extension.
The main goal of this is to make mdex an optional dependency for
Tableau, so a Tableau release is not required when mdex updates or makes
breaking changes.
convertcallback toTableau.ExtensionTableau.Converter.convertfunction for extensions to usedirectory, and will convert them if there is a matching converter for
that extension. Frontmatter is still required.
Breaking Changes
mdexis an optional dependency, so you must add it to your deps yourself.lumissyntax highlighter with mdex, you must also add that as a dep yourself.instead of the
:configkey.Tableau.Converter.convertnow just takes contentand opts.
Tableau.Converteris no longer a behaviour.convertcallback.Tableau.markdownis removed. UseTableau.Converterinstead.