Repository navigation
install-blobs, flash-self: handle a failing blob_status - #53
Merged
Merged
Conversation
…nstall" install-blobs now fails when the pod does not list its blob slots, with the pod's reason (a dev build answered "reply too large"). flash-self, whose firmware is already in at that point, prints a warning naming the blobs it skipped and the retry (`benchpod install-blobs`) instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pod on a dev build answered `blob_status` with "reply too large", and `flash-self` installed no blobs without saying so clearly.
Tests (fakes only, no hardware): `TestFlashSelfNetworkWarnsWhenBlobStatusFails`, `TestInstallBlobsAfterFlashWarnsWhenTheSlotsAreNotListed`, `TestInstallBlobsFailsWhenBlobStatusFails`, `TestInstallBlobsBuiltInIsNotABlobStatusFailure`. `go vet ./... && go test ./...` green.
🤖 Generated with Claude Code