Repository navigation
Security: OpenOCD quoting in flash; flash-self requires a signed download over https - #55
Open
wardviaene wants to merge 2 commits into
Open
wardviaene wants to merge 2 commits into
wardviaene wants to merge 2 commits into
Conversation
The firmware path goes in braces and --load-address must be a number, so [exec ...] in a file name or address cannot run a command through OpenOCD's Tcl. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd plain-http downloads A download (default release, URL or --firmware-url) must carry a signature this CLI knows; --allow-unsigned flashes it anyway. A local file is only reported on. http:// is refused except for localhost. README updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the 2026-11-14 security review (findings 5 and 7):
flash: the firmware path goes in braces in OpenOCD's program command and--load-addressmust be a number, so[exec ...]in a name or address cannot run a command. Windows paths are passed with forward slashes.flash-self(USB and--network): a downloaded image must have a signature this CLI knows, else it is refused (--allow-unsignedflashes it anyway). A local file is only reported on, so your own builds still flash. Downloads must be https (localhost excepted).🤖 Generated with Claude Code