Repository navigation
Security: flash() keeps Tcl out of OpenOCD's program command (SDK 2.13.17) - #80
Merged
Merged
Conversation
…3.17) The firmware path goes in braces and load_address must be a number, so a file name or address like [exec ...] cannot run a command through OpenOCD's Tcl. Windows paths are passed with forward slashes; a path with a brace is refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenOCD runs the
program <file> <load_address> ...string as Tcl, so[exec ...]in a file name or load address ran a command on the machine running the flash. The embeddedci server runs this for the AI tab, so it was a server-side command injection (the server now also checks the arguments itself).load_addressmust be a number (hex or decimal).The MCP 2.13.17 (requiring this SDK) follows in its own PR once this is on PyPI.
🤖 Generated with Claude Code