Skip to content

Security lows: credentials stay on their origin across redirects; MCP loopback Host/Origin checks, --auth-token-file (2.13.18) - #82

Open
wardviaene wants to merge 1 commit into
mainfrom
redirect-auth
Open

wardviaene wants to merge 1 commit into
mainfrom
redirect-auth

Conversation

@wardviaene

Copy link
Copy Markdown
Member

From the 2026-11-14 security review (findings 12 and 13):

  • SDK: every call that carries credentials (server API, cloud transport and auth, lease, CI, AI Vision, CLI login) goes through embeddedci._http.urlopen, whose redirect handler drops Authorization, X-Benchpod-Lease and cookies when the redirect changes host, port or scheme. Tests that patched urllib.request.urlopen now patch embeddedci._http.urlopen.
  • MCP HTTP transport: a loopback bind sets DNS-rebinding protection explicitly (loopback Host and Origin on its port), checked by hand: foreign Host 421, foreign Origin 403, loopback 200. --auth-token-file, and the help says a command-line token shows in ps. README updated.

🤖 Generated with Claude Code

…opback Host/Origin checks and --auth-token-file (MCP) - 2.13.18

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant