Skip to content

EmDash 1.4 peer catch-up - #60

Merged
cavewebs merged 1 commit into
mainfrom
cursor/emdash-1-4-peer-baf2
Nov 2, 2026
Merged

cavewebs merged 1 commit into
mainfrom
cursor/emdash-1-4-peer-baf2

Conversation

@cavewebs

Copy link
Copy Markdown
Contributor

I widened @dashcommerce/core's emdash peer so 1.4 installs work, without bricking 0.37.x.

Peer: >=0.37.0 <0.38.0 || >=1.1.0 <1.5.0. The runtime check matches that range. I shipped patches/emdash@1.4.0.patch (same request-body clone and raw Response passthrough as 1.3.1, retargeted at 1.4.0's hashed files). Core's emdash and @emdash-cms/admin devDeps track 1.4.0. CI matrix includes 1.4.0.

Patch bump changeset is in for 0.3.3. Do not merge a Version Packages PR from this.

Open in Web Open in Cursor 

Widen the 1.x peer to <1.5.0, ship the 1.4.0 hashed-dist patch, and
point core's emdash / @emdash-cms/admin devDeps at 1.4.x.

Co-authored-by: Timchosen Uzua <timchosen@gmail.com>
@cavewebs
cavewebs merged commit 0d13b12 into main Nov 2, 2026
8 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 2, 2026
cavewebs added a commit that referenced this pull request Nov 2, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @dashcommerce/core@0.3.3

### Patch Changes

- [#60](#60)
[`37b9afc`](37b9afc)
Thanks [@cavewebs](https://github.com/cavewebs)! - Support EmDash 1.4.0.
Ship `patches/emdash@1.4.0.patch` (same raw Response passthrough and
request body clone fix as 1.3.1, retargeted at 1.4.0's hashed dist
files). Widen the EmDash peer range to `>=0.37.0 <0.38.0 || >=1.1.0
<1.5.0` so create-emdash 1.4 installs pass peer checks. Cap below 1.5 so
the next untested EmDash minor is still rejected.
## @dashcommerce/starter@0.3.8

### Patch Changes

- Updated dependencies
[[`37b9afc`](37b9afc)]:
  - @dashcommerce/core@0.3.3
@cavewebs cavewebs mentioned this pull request Nov 5, 2026
cavewebs added a commit that referenced this pull request Nov 5, 2026
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
# Releases

## @dashcommerce/core@0.3.4

### Patch Changes

- Republish with a fresh build so the shipped dist matches main (EmDash
peer `<1.5.0` / runtime version-check). npm 0.3.3 incorrectly shipped
the 0.3.2 dist. See
[#63](#63).

## @dashcommerce/starter@0.3.9

### Patch Changes

- Updated dependencies:
  - `@dashcommerce/core@0.3.4`

## Why this bump

npm's published `@dashcommerce/core@0.3.3` has the correct
`package.json` peer (`emdash` `>=0.37.0 <0.38.0 || >=1.1.0 <1.5.0`) but
the shipped dist is still the 0.3.2 build:

- `dist/index.js` has `var version = "0.3.2"`
- `dist/version-check` still has `SUPPORTED_EMDASH_PEER = ">=0.37.0
<0.38.0 || >=1.1.0 <1.4.0"`

Source on `main` already has the `<1.5.0` range from #60. The 0.3.3
publish packed a stale dist. This PR only bumps versions so 0.3.4 can be
rebuilt and published.

Also updates `packages/core/README.md` so the hardcoded npm version line
is `0.3.4` instead of the stale `0.2.2`.

## After merge: rebuild before publish

Do not publish from the existing `dist/`. After this lands on `main`:

1. Rebuild: `cd packages/core && bun run build`
2. Confirm local dist has `0.3.4` and the runtime peer range `<1.5.0`
3. Publish 0.3.4 to npm `next`
4. Inspect the tarball (`npm pack` or the published files):
`dist/index.js` version is `0.3.4`, version-check peer is `<1.5.0`
5. Promote `next` to `latest`

Skip the rebuild and 0.3.4 will ship another stale dist, same as 0.3.3.
<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-b5cf338f-37c8-5d08-b162-9b6bdc6668fa?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-b5cf338f-37c8-5d08-b162-9b6bdc6668fa&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants