[endrix]

Phase 1 of the declutter review (pure deletions, no behaviour change) for packages/shared, packages/diagram-server and packages/diagram-client. 43 files changed, 75 insertions(+), 2610 deletions(-).

Element types the model never emits (shared, client, server)

node:proxy, node:collapsed:conditional, node:collapsed:array, node:structure:if:branch, node:structure:if:join, node:structure:foreach:join, node:structure:if:inline, node:join, edge:virtual, comp:ports, comp:port-row had a client model class, a view, a registration, a server type mapping, a shape hint and layout-configurator/ELK branches, and no producer: the graph builder emits then/else/foreach containers directly. Gone with them: nine metadata keys only they carried, the three type guards that always returned false, their CSS rules, and the per-submit model walk in the submission handler that logged virtual edges. The parity baseline fixture loses the ten registrations.

Shared dead exports

NODE_ENTITY, PORT_IN/PORT_OUT, NODE_JOIN, the WORKFLOW_* metadata twins except WORKFLOW_NAME, HAS_EXTERNAL_MEMBERS, PORT_INDEX, NETWORK_VARIABLES/INPUT_PORTS/OUTPUT_PORTS, the Origin helpers, the entity/port type guards (isReadOnlyElement stays), six sizing constants, the model's two never-populated AST maps and its workflow field, and the WorkflowDiagramCss members no TypeScript references.

Client

• The "Change referenced type" round-trip (requestWorkspaceEntities / showWorkspaceEntities / updateEntityInstanceType) and dialogram.toggleGrid: no handler anywhere (the host's grid command dispatches GLSP's own action). The propertySections.entityType flag stays, it still hides the row.
• go-to-source-context-menu-provider.ts, open-source-mouse-listener.ts: imported by nothing.
• di.config.ts, shared-webview-messenger.ts and the index's back-compat block: no caller in dialogram or any product.
• The wf:labelRole read (no producer; type labels are drawn by the node view), wf:namespace → namespaceName (no reader), WorkflowEditableLabel, ValidationDecoration, isAnyDragActive, isDragActiveForEdge and the write-only map behind it, workflowDiagramViewMap, the chat.sessionLoaded case (the host never sends it).
• 39 stylesheet selectors whose class names nothing produces. Checked with a producer scan over the client, scripts, chisel-ide, mlir-viewer and the GLSP/sprotty/vscode-elements dists, treating template-built prefixes as producers, so this list is shorter than the review's.

Server

• The serpentine layout's seeding router (seedEdgeRoutesForFixedLayout and its helpers): every seeded route was overwritten by the reroute the handler runs right after (resetAll routes every edge; with a selection, unselected routes are restored from the pre-op snapshot). The ELK call and the fixed branch stay.
• layout-key-migration.ts (no caller) and seven LayoutPersistenceService methods with no caller.
• clipboard.ts: the parser and escapeRegExp no paste path reads. The copy payload itself is untouched (that is phase 2).
• Context menu: the "Stable, Experimental" reroute entry and the routingStrategy flag the handler never read; navigationTargetFromElement (a copy of sourceTargetFromElement). "Clear Routes Only" stays: it dispatches a real handler.
• elkDefaults.defaultLayoutOptions: emptied. Verified with elkjs that defaults apply only to a root without options of its own, and the configurator always hands the root a full set, so the old values were never read.
• agentPersona: no caller set it.

Kept from the review's list, and why

• diagram-glsp-module.ts facade: four sidecar-toolkit tests import WorkflowSourceModelStorage through it; that package is in the other phase-1 PR.
• The legacy layout-file locations and the single-network payload reader: layout-persistence-multi-network.test.ts pins reading from the old location, so both stay.
• The wf:edgeOpenAnchorX/Y args: the review called them unproduced, but the edge-open mouse listener writes them on hover and the edge view reads them. Live.
• WorkflowDiagramCss.NODE_STRUCTURE_IF_BRANCH: the server still stamps it on then/else/foreach nodes.
• The @eclipse-glsp/server type import in shared: swapping it for @eclipse-glsp/graph means a dependency change and lockfile churn; left for a dependency pass.

Verification

npm run typecheck 5/5, npm run check:neutrality 5/5, npm run build ok. Tests: diagram-server 441/441, diagram-client 361/361 (one trace test for virtual edges removed with the type), extension-core 344/344. sidecar-toolkit: 5 timeouts in variant-node-create-wizard.test.ts that reproduce on untouched main (5 s limits), unrelated to this change.

https://claude.ai/code/session_01EToj6RJRMSSHQiqGNMU9wv