Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,18 @@ platform API version.

### Removed

- **The `@path` annotation editor and its wizard template.** No producer has
a `@path` decorator: wfpy sets a workflow's tool search paths with
`@config(path=[...])`. The property panel's editor never rendered, and the
wizard's "external tool search paths" template wrote `@path(...)`, which the
Python source cannot import. A `path` annotation a project defines itself
still opens in the generic editor.
- **Agent and tool keys nothing reads**: `wf:toolSpec` on tool nodes (the
external-actor flag stays), `cal:agentStateful` and its constant
`WorkflowDiagramMetadata.AGENT_STATEFUL` (a removal from the shared API, for
the next minor version), the never-called agent-metadata reset in the model
storage, and the property panel's unused tab builder with its stylesheet
rules, and its inline-Markdown renderer with the helper only it called.
- **Element types the model never emits**, with their client classes and
views, server mappings, shape hints and layout branches: `node:proxy`, the
two collapsed nodes, the if-branch, if-join, foreach-join and inline-if
Expand Down
36 changes: 0 additions & 36 deletions packages/diagram-client/src/editing-action-handlers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,6 @@ export class WorkflowEditAnnotationsActionHandler implements IActionHandler {
items: [
{ id: 'tool', label: '@tool (external execution)', description: 'cmd, args, inheritStdio, ...' },
{ id: 'viewer', label: '@viewer (open outputs in VS Code)', description: 'open, diff, openWith (viewType)' },
{ id: 'path', label: '@path (external tool search paths)', description: 'paths=["./bin", "./tools"]' },
{ id: 'custom', label: 'Custom annotation…', description: 'Enter any name and arguments' }
],
placeHolder: 'Choose an annotation template'
Expand Down Expand Up @@ -720,41 +719,6 @@ export class WorkflowEditAnnotationsActionHandler implements IActionHandler {
if (title === undefined) return;
annotationText = `@viewer(\n action="diff",\n inputs=${inputsExpr.trim()},\n token="last",\n title=${toWfStringLiteral(title)}\n)`;
}
} else if (template === 'path') {
annotationName = 'path';

const paths: string[] = [];

for (;;) {
const next = await VscodeUi.instance.inputBox({
prompt: paths.length === 0 ? 'Add path (e.g. ./bin)' : 'Add another path (optional)'
});
if (next === undefined) return;
const trimmed = next.trim();
if (trimmed) {
paths.push(trimmed);
}

if (paths.length === 0) {
continue;
}

const addMore = await VscodeUi.instance.quickPick({
items: [
{ id: 'yes', label: 'Add another path' },
{ id: 'no', label: 'Done' }
],
placeHolder: 'Add another path?'
});
if (addMore !== 'yes') {
break;
}
}

if (paths.length === 0) return;

const listExpr = `[${paths.map(p => toWfStringLiteral(p)).join(', ')}]`;
annotationText = `@path(\n paths=${listExpr}\n)`;
} else {
const name = await VscodeUi.instance.inputBox({
prompt: 'Annotation name (without @)',
Expand Down
5 changes: 0 additions & 5 deletions packages/diagram-client/src/markdown.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ export function renderDocumentMarkdownSafe(src: string): string {
return DOMPurify.sanitize(documentMd.render(src));
}

/** Render inline Markdown (no block wrapping) to sanitized HTML. */
export function renderInlineMarkdownSafe(src: string): string {
return DOMPurify.sanitize(md.renderInline(src));
}

/**
* Cheap heuristic for "is this worth rendering as Markdown?" — used to keep
* plain text in pre-wrap form instead of paying markdown layout for it.
Expand Down
76 changes: 0 additions & 76 deletions packages/diagram-client/src/property-panel.css
Original file line number Diff line number Diff line change
Expand Up @@ -47,64 +47,6 @@
container-name: pp-panel;
}

/* ============================================
Property Panel Tabs
============================================ */

.property-tabs-header {
position: sticky;
top: 0;
z-index: 10;
display: flex;
flex-direction: row;
overflow-x: auto;
border-bottom: 1px solid var(--vscode-panel-border);
background: var(--vscode-editorGroupHeader-tabsBackground, #2d2d2d);
-ms-overflow-style: none;
scrollbar-width: none;
flex-shrink: 0;
}

.property-tabs-header::-webkit-scrollbar {
display: none;
}

.property-tab-btn {
flex: 0 0 auto;
padding: 8px 12px;
background: transparent;
border: none;
border-bottom: 1px solid transparent;
color: var(--vscode-tab-inactiveForeground, #8b8b8b);
cursor: pointer;
font-size: 11px;
font-weight: 600;
letter-spacing: 0.3px;
text-transform: uppercase;
transition: color 0.15s ease, border-color 0.15s ease;
outline: none;
}

.property-tab-btn:hover {
color: var(--vscode-tab-hoverForeground, #cccccc);
background: var(--vscode-list-hoverBackground, rgba(90, 93, 94, 0.31));
}

.property-tab-btn.active {
color: var(--vscode-tab-activeForeground, #ffffff);
border-bottom: 1px solid var(--vscode-focusBorder, #007fd4);
}

.property-tab-content {
display: none;
flex-direction: column;
height: 100%;
}

.property-tab-content.active {
display: flex;
}

.property-panel.collapsed {
transform: translateX(-100%);
}
Expand Down Expand Up @@ -588,24 +530,6 @@
letter-spacing: 0.6px;
}

/* Tabs: minimal, accent underline. */
.property-tabs-header {
background: transparent;
border-bottom: 1px solid var(--pp-border);
}
.property-tab-btn {
color: var(--pp-muted);
border-bottom-color: transparent;
}
.property-tab-btn:hover {
color: var(--vscode-foreground);
background: transparent;
}
.property-tab-btn.active {
color: var(--vscode-foreground);
border-bottom-color: var(--pp-accent);
}

/* Sections: plain header (no fill), hairline separators between sections. */
.property-section {
border-bottom: 1px solid var(--pp-border);
Expand Down
Loading
Loading