Repository navigation
refactor: the platform no longer discovers agent skills and presets - #139
Merged
Merged
Conversation
wfpy-ide asks its own host for an @agent task's skills and agent presets (endrix/wfpy-ide#26, #27) and holds the agent workflow UI itself, so the platform's copies go: - Server: the per-load agent enrichment in WorkflowSourceModelStorage (about 400 lines: the warm-or-defer scan of .wf/skills, .claude/skills, ~/.claude/skills and the .claude/agents directories on every diagram load of every product, the skills and presets snapshots on the root, the skill status on @agent nodes, the cache, and the second model refresh it dispatched when the scan found something); the two discovery operation handlers (request-agent-skills-handler.ts, request-claude-agents-handler.ts) and their tests; the refresh-agent-enrichment- polling prefix. - Client: the discovery requests, answers and their handlers' caches in editing-action-handlers.ts; src/agent-ui/ (agentUiModule), its tests and its path-import fixture. The contribution-point tests keep a neutral panel harness (test/panel-harness/) and exercise the points with their own probes. - Toolkit tests: the enrichment deferral test, and the stub of applyAgentEnrichment the others carried. The cal:agentSkillStatus key stays in the shared metadata for now: wfpy-ide's Skill row still writes it. The load breadcrumb keeps its skillStatus/skills/agents phases, which now read 0. wfpy-ide main passes its 138 tests and builds its bundle against this tree. Claude-Session: https://claude.ai/code/session_01EToj6RJRMSSHQiqGNMU9wv
- The load breadcrumb no longer has agent-enrichment phases: the skillStatus/skills/agents buckets, setEnrichment and the enrichment= field always read 0 or n/a. Its test pins that they are gone. - Docs that described the deleted scan: both READMEs' debugging note (the one in the VSIX too), the caller-redelivery guard's comment and a toolkit test's comment. - The CHANGELOG's release note names #137 and #139 among what needs the 0.9 bump; the contribution-points entry no longer credits the platform with fixes to code that has left it. - Tests: the neutral panel harness drops the viewer-editor bridge defaults only the @viewer template used; the node-section test that passed trivially (the platform has nothing that could draw agent sections) is gone; a new one pins that a redraw a contribution asks for tells the annotation editors not to request discovery again, which only wfpy-ide's tests checked after the agent UI left. Claude-Session: https://claude.ai/code/session_01EToj6RJRMSSHQiqGNMU9wv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 3, last step for the agent stack (P5e). wfpy-ide now holds the agent workflow UI and asks its own host for skills and presets (endrix/wfpy-ide#24, #26, #27, all merged). This deletes the platform's copies, including the original reason for the whole move: every product's diagram load scanned the skill and agent directories and could rebuild the model a second time.
Removed
WorkflowSourceModelStorage, about 400 lines:.wf/skills,.claude/skills,~/.claude/skillsand the.claude/agentsdirectories, run on every diagram load of every product;wf:agentSkillsSnapshot/wf:claudeAgentsSnapshotsnapshots on the root, and the skill status on@agentnodes;request-agent-skills-handler.ts,request-claude-agents-handler.ts), their registrations and their tests.refresh-agent-enrichment-polling prefix.editing-action-handlers.ts;src/agent-ui/(agentUiModule), its 32 tests, which moved to wfpy-ide, and its path-import fixture.applyAgentEnrichmentstub seven other tests carried.54 files changed: 178 lines added, 6,856 deleted.
Kept
AnnotationEditor,NodeSectionContribution,AnnotationTemplate). Their tests now use a neutral panel harness (test/panel-harness/) and their own probes instead of the agent UI. The template tests' quoting cases moved to wfpy-ide with the templates.cal:agentSkillStatusmetadata key, because wfpy-ide's Skill row still writes it.Review (
/code-review medium), addressedThe review found no correctness bug in the deletions, and nothing left in the tree references the removed handlers, action kinds, caches or
agentUiModule. Fixed:skillStatus/skills/agentsbuckets,setEnrichmentand theenrichment=field, which would only have read 0 or n/a. Its test pins that they are gone.@viewertemplate used.Release
This is breaking for the API: the discovery actions and
agentUiModulego, thoughagentUiModulewas never released. It belongs to the 0.9 release, whose note[Unreleased]already carries.Tests
variant-node-create-wizard, which passes in CIhttps://claude.ai/code/session_01EToj6RJRMSSHQiqGNMU9wv