Skip to content

fix: sessions sorted by time are deterministic, in the code and in its test #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
endrix merged 2 commits into from
Nov 9, 2026
Merged

fix: sessions sorted by time are deterministic, in the code and in its test #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e96b66
test: sessions sorted by time are created at distinct times
endrix Nov 9, 2026
f3ebc6e
fix: sessions with the same time list the later one first
endrix Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/extension-core/src/extension/session-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,15 @@ export class SessionManager {
* Get all sessions for a specific workflow file
*/
getSessionsForWorkflow(workflowFile: string): SessionData[] {
// Most recent first; between equal times (created or restored in the same
// millisecond), the one added later.
return Array.from(this.sessions.values())
.filter((s) => s.workflowFile === workflowFile)
.sort((a, b) => b.updatedAt - a.updatedAt);
.map((session, order) => ({ session, order }))
.filter(({ session }) => session.workflowFile === workflowFile)
.sort((a, b) => b.session.updatedAt - a.session.updatedAt
|| b.session.createdAt - a.session.createdAt
|| b.order - a.order)
.map(({ session }) => session);
}

/**
Expand Down
35 changes: 29 additions & 6 deletions packages/extension-core/test/session-manager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,17 +247,40 @@ describe('SessionManager', () => {

describe('getSessionsForWorkflow', () => {
it('should return sessions for specific workflow', async () => {
await sessionManager.createSession('/test/workflow1.py', 'Session 1');
mockACPClient.createSession.mockResolvedValue('session-2');
await sessionManager.createSession('/test/workflow2.py', 'Session 2');
mockACPClient.createSession.mockResolvedValue('session-3');
await sessionManager.createSession('/test/workflow1.py', 'Session 3');
// Each session at its own time, so the order is the updatedAt sort's.
vi.useFakeTimers({ toFake: ['Date'] });
try {
vi.setSystemTime(1_000);
await sessionManager.createSession('/test/workflow1.py', 'Session 1');
vi.setSystemTime(2_000);
mockACPClient.createSession.mockResolvedValue('session-2');
await sessionManager.createSession('/test/workflow2.py', 'Session 2');
vi.setSystemTime(3_000);
mockACPClient.createSession.mockResolvedValue('session-3');
await sessionManager.createSession('/test/workflow1.py', 'Session 3');
} finally {
vi.useRealTimers();
}

const sessions = sessionManager.getSessionsForWorkflow('/test/workflow1.py');

expect(sessions).toHaveLength(2);
// Sessions are sorted by updatedAt descending (most recent first)
expect(sessions.map((s) => s.name)).toEqual(['Session 1', 'Session 3']);
expect(sessions.map((s) => s.name)).toEqual(['Session 3', 'Session 1']);
});

it('should put the later of two sessions with the same time first', async () => {
vi.useFakeTimers({ toFake: ['Date'] });
try {
vi.setSystemTime(5_000);
await sessionManager.createSession('/test/same.py', 'Earlier');
mockACPClient.createSession.mockResolvedValue('session-later');
await sessionManager.createSession('/test/same.py', 'Later');
} finally {
vi.useRealTimers();
}

expect(sessionManager.getSessionsForWorkflow('/test/same.py').map((s) => s.name)).toEqual(['Later', 'Earlier']);
});

it('should return empty array for workflow with no sessions', () => {
Expand Down
Loading