Repository navigation
lib-portal: page paths relative to the portalScope key - #92
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L8TCeZWgJjKTDhmntR9JtB
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Scope reuse guidance incorrectly includes pages outside a nested content scope, and one parameter description is grammatically incomplete.
2 open findings
What changed in this PR
Documents XP’s updated portal-scope URL semantics.
Changes:
- Defines paths relative to the content named by
portalScope.key. - Clarifies
baseUrlcomposition and affected return types. - Updates XP 8.1 upgrade guidance.
| File | Description |
|---|---|
docs/upgrade.adoc |
Updates migration guidance for portalScope(). |
docs/libraries/lib-portal.adoc |
Revises portal scope, URL parts, and HTML processing reference documentation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L8TCeZWgJjKTDhmntR9JtB
anatol-sialitski
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs for enonic/xp#12441 (enonic/xp#12442): page paths are relative to the content the
portalScopekey names, andbaseUrlis the configured Base URL followed by its path below the site or project.🤖 Generated with Claude Code
https://claude.ai/code/session_01L8TCeZWgJjKTDhmntR9JtB
Generated by Claude Code