Repository navigation
feat(design-client): add getDesignVariables operation - #618
Merged
Merged
Conversation
Sync the design builder API spec, which also adds createDesignDocumentJob, getDesignDocumentJob and duplicateDesignAsV1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
getDesignVariables(GET /v1/designs/{designId}/variables, permissiondesign:view) to@epilot/design-client. It returns{ design_id, variables }, wherevariablesholds the design as flatdesign.*template variables (Components.Schemas.GetDesignVariablesRes). svc-email-templates-api needs it in the typed client.The spec comes from
packages/svc-design-builder-api-specs/openapi.ymlon branchfeat/design-variablesof svc-design-builder-api (MR !219, still open). The endpoint is not in the prod spec yet, so this PR should merge only after that MR is deployed.Syncing the spec also adds three operations that are already live in prod but were missing from the client:
createDesignDocumentJob(POST /v1/designs/document/generate/jobs)getDesignDocumentJob(GET /v1/designs/document/generate/jobs/{jobId})duplicateDesignAsV1(POST /v1/designs/{designId}/duplicate-as-v1)No operations or schemas were removed. The remaining diff consists of description text updates.
Release
The changeset adds a
minorbump, from 0.6.0 to 0.7.0. npm's latest version is 0.5.7 because 0.6.0 was never published.Testing
npm run typegen && npm run buildvitest run: 3/3 passedGenerated by Claude Code