Repository navigation
feat(pricing-client, targeting-client): product recommendation rule table - #620
Merged
Merged
Conversation
…able - @epilot/pricing-client 3.66.0: Pricing API 1.3.0 spec, adds `campaign_id` to `ProductRecommendationSearch` (rule table schemas from 1.2.4 were already in the client) - @epilot/targeting-client 0.21.0: `rules` on `SetupNewProductRecommendation`, new `ProductRecommendationRule`, `ProductRecommendationOfferGroup`, `SetupCampaignRuleError` schemas, `maxItems: 1` on `product_recommendations`, `email_engagement` filter, 403/503 responses Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012h2oEFg2vbGeGsCBZspGn4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates two clients to the current specs on
mainof the source APIs. The specs were regenerated withscripts/update-openapi.js(openapi.json+openapi-runtime.json), thennpm run typegen(openapi.d.ts).@epilot/pricing-client3.65.3 → 3.66.0 (Pricing API 1.3.0)ProductRecommendationSearch.campaign_id(optional): asks for the offers from a tariff change campaign's rule table. It is used together withcontract_id.ProductRecommendationRuleand related) were already in the client (9836685), so nothing changes there.@epilot/targeting-client0.20.0 → 0.21.0 (Targeting API 1.1.0, latestmain)SetupNewProductRecommendation.rules?: ProductRecommendationRule[]ProductRecommendationRuleProductRecommendationOfferGroupSetupCampaignRuleError: thesetupCampaign400 response is nowClientError | SetupCampaignRuleError.product_recommendationsgetsmaxItems: 1. Its generated type changes from a tuple with rest elements to a single-item tuple.EmailEngagementschema and anemail_engagementquery parameter ongetRecipientssetupCampaign,discoverCampaigns,updateRecipientEntityUiStatusandrestoreRecipientEntityUiStatusVersioning
Both
package.jsonversions were bumped by a minor version, following the recent direct-bump pattern for these two clients (CONTRIBUTING:npm version minor --no-git-tag-version). There is no changeset, so a laterchangeset versionwill not bump them a second time.How it gets released
@epilot/sdk: released automatically. This PR changesclients/*/src/openapi.json,openapi.d.tsandopenapi-runtime.json. The auto-release job checksgit diff HEAD~1 HEADon the push tomain.packages/epilot-sdk-v2(pnpm --filter @epilot/sdk generate), bumps the patch version, tags it and publishes.packages/epilot-sdk-v2output is left out of this PR on purpose, as in previous client PRs, because the auto-release commit produces it.[skip release]in the merge commit message. A rebase merge would also work, because the last commit contains the spec files.@epilot/pricing-client/@epilot/targeting-client(standalone npm packages): these are not auto-released. A maintainer publishes them after merge (pnpm publishin each client folder orpnpm publish-packages). Nothing was published from this PR.Test plan
npm run buildin both clientsvitestin both clients (3/3 each)pnpm lint(biome, repo-wide) is cleanpnpm generate-sdk, then build and test of@epilot/sdklocally: 376/376 pass. Only the pricing/targeting types, docs and definitions changed, which shows the rest of the SDK was already in sync.campaign_id(pricing) andrules,ProductRecommendationRuleandSetupCampaignRuleError(targeting).Generated by Claude Code