Repository navigation
feat(ui): release 5.3.0 with folder groups that open and close in Nav - #210
Merged
Merged
Conversation
matthewmr-eqty
marked this pull request as draft
October 30, 2026 19:53
matthewmr-eqty
force-pushed
the
feat/grd-193-nav-expandable
branch
from
October 30, 2026 19:56
67edc09 to
7e9d852
Compare
matthewmr-eqty
marked this pull request as ready for review
October 30, 2026 20:09
This was referenced Oct 30, 2026
matthewmr-eqty
marked this pull request as draft
October 30, 2026 20:41
matthewmr-eqty
marked this pull request as ready for review
October 30, 2026 20:53
tmccoy14
reviewed
Nov 2, 2026
tmccoy14
left a comment
Contributor
There was a problem hiding this comment.
Nice work on the folder groups. A handful of things below; the version clash is the one that blocks merging.
matthewmr-eqty
force-pushed
the
feat/grd-193-nav-expandable
branch
from
November 2, 2026 16:39
014ea8b to
2dc1170
Compare
tmccoy14
approved these changes
Nov 2, 2026
Need: Docs sites and apps need sidebar folders readers can open and close, built from Equality instead of hand-rolled. Problem: Nav could only drill into a new level, so a docs tree had no Equality part, and its hints each set their own colour. Solution: NavListExpandable adds folders that keep their links in server HTML and open around the current page. One muted colour styles every hint, and new-tab rows draw their own ↗. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er arrow under reduced motion Need: Readers in high-contrast mode, or with reduced motion on, need the same cues as everyone else. Problem: Forced colours boxed every row and left the current rail item unmarked; a folder's arrow still turned with reduced motion on; a leaving drill level jumped 12px under a switcher; a nudge of 0 still nudged. Solution: Only the current row and rail item keep a border in forced colours, the arrow drops its transition, the leaving level keeps the switcher gap, and a 0 nudge is honoured. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…m one gap Need: Apps on 5.2.0 get Nav folders that behave the same through drills, themes and every header. Problem: NavDrill rebuilt levels and lost folder state and current styling, Badge and Icon put divs in buttons, and nav spacing was padding plus special cases. Solution: Folders remember their state by `value`, ghost rows count as current, Badge and Icon render spans, the nudge resolves any length, and containers own one 2px gap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…em collapsed Need: Readers with JavaScript off can reach every link in a Nav folder, and screen readers hear its true state. Problem: Closed folders stayed shut with no way to open them, and server HTML announced them as collapsed; the docs site worked around it by reaching into Equality's markup. Solution: Under `scripting: none` every folder shows open without its arrow, and the trigger leaves `aria-expanded` out until it mounts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
matthewmr-eqty
force-pushed
the
feat/grd-193-nav-expandable
branch
from
November 2, 2026 17:06
42ccb2f to
9993bd5
Compare
…e-merge # Conflicts: # packages/ui/CHANGELOG.md
matthewmr-eqty
added a commit
that referenced
this pull request
Nov 3, 2026
Need: Sites upgrading to @eqtylab/docs 0.16.0 need the Equality release its sidebar is built from. Problem: The peer range allowed 5.2.0, the Button release, which has no Nav folders. Solution: Require 5.3.0, the release #210 shipped them in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need
Docs sites and apps need sidebar folders readers open and close, built from Equality rather than hand-rolled.
Problem
Nav could only drill into a new level, so a docs tree had no Equality part. Its hints each set their own colour, apps hand-built new-tab arrows, and nav spacing came from each part's own padding, with special cases.
Change
NavListExpandableadds folders that keep their links in server HTML, open themselves around thecurrentrow, and move with the drill's motion, now named once as--eq-nav-motion-*.--eq-list-item-muted-colorcolours every hint (›, ⌄, ‹, ↕, ↗). Each takes its row's colour on hover and on the current row.target="_blank"rows draw their own ↗, "(opens in a new tab)" andrel.--eq-switcher-name-fadelets a site set its fade.NavDrillkeeps each folder's state by itsvalue.BadgeandIconrender spans, so they're valid inside a folder header.aria-expandeduntil it loads.MotionCollapsibleContentno longer grows when it first renders open.Evidence
astro checkpass on this commit alone.Review focus
Merging publishes 5.3.0. Start with
NavListExpandableand how a folder opens around the current row innav-list.tsx, thennav-list.module.cssandnav.module.css. Studio sees four changes on upgrade: a quieter ›, hover fills only with a mouse, plain-title panels 6px lower, andBadgeandIcontyped as spans. The Nav page that documents all this is its own PR, after this one.Not covered
Studio's
e2e/policy-subnav.spec.tshasn't run against 5.3.0 (GRD-192). The live Nav page lags these parts until the docs PR merges.@eqtylab/docs0.16.0 follows and must drop its own ↗.Flow
Part of GRD-193 · GRD-81
🤖 Generated with Claude Code