Repository navigation
format: state the sort of pointer variables - #404
Merged
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pointer expression schema never said what sort a variable has. Its list of sorts put variables under integers only when they "denote an index or count", and the
Variabledefinition said only that a variable evaluates to its value. The pointers package already keeps the sort of a variable's defining expression (and tests it), so a variable defined by a bytes expression keeps its width.This states that in the schemas:
eachvariable is an integer, and a variable from a scope'sdefinehas the sort of the expression that defines it.m["abc"]for amapping(string => uint256)).eachis an integer.expected variable takes its value, and so its sort, from the variable in scope where the template is referenced.This matters for mapping entries keyed by
stringorbytes, whose raw key bytes have no fixed width and can't round-trip through an integer.