Skip to content

conformance: shim SolDB dropping the resources stamp - #407

Merged
gnidan merged 1 commit into
mainfrom
conformance-soldb-stamp
Nov 10, 2026
Merged

gnidan merged 1 commit into
mainfrom
conformance-soldb-stamp

Conversation

@gnidan

@gnidan gnidan commented Nov 10, 2026

Copy link
Copy Markdown
Member

Stacked on #405. SolDB drops the ethdebug stamp from the resources object it reads (#406), so the SolDB resources test now compares against solc's resources without the stamp, with a tripwire that fails once SolDB keeps it. The conformance README now describes this process for any divergence between the format and a tool.

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2
Preview removed because the pull request was closed.
2026-11-10 07:23 UTC

Base automatically changed from conformance-solc-stamp to main November 10, 2026 07:10
SolDB rebuilds a bare resources object from only `compilation`, `types`
and `pointers`, so it drops the `ethdebug` stamp that solc now emits.
The SolDB resources test compares against solc's resources without the
stamp, and a tripwire fails once SolDB keeps it.

The conformance README now describes how the tests handle a divergence
between the format and a tool.

Refs #406
@gnidan
gnidan force-pushed the conformance-soldb-stamp branch from 0c430a9 to d62ab0e Compare November 10, 2026 07:12
@gnidan
gnidan merged commit 9b2daf8 into main Nov 10, 2026
8 of 9 checks passed
@gnidan
gnidan deleted the conformance-soldb-stamp branch November 10, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant