Repository navigation
bugc: check each example's code digest in its own test - #410
Merged
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test that checks the code does not depend on invoke/return markers compiled every example at every optimizer level inside one
it, 192 compilations in all. It takes about a second on a fast machine but went over vitest's 5 s limit on CI under load (seen on #408). Each source and level is now its own test, the same as the other tests in the file, so no single test comes near the limit and a changed digest names its example and level. All 192 digests are unchanged; only the snapshot keys moved.The changelog check counted the snapshot file as a source change, so it now skips
*.test.ts.snapthe same as test files.