Repository navigation
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 9a278ed | Commit Preview URL Branch Preview URL |
Nov 06 2026, 05:39 AM |
| ruff_python_stdlib = { version = "0.0.14" } | ||
| ruff_source_file = { version = "0.0.14" } | ||
| ruff_text_size = { version = "0.0.14" } | ||
| ruff_python_ast = { version = "0.0.15" } |
There was a problem hiding this comment.
[P2] The ruff 0.0.15 cap is correct (0.0.x caret semantics pin it exactly, and the toolchain is pinned to 1.96.0 in rust-toolchain.toml), but nothing in the manifest records why ruff is held back while everything else floats. The PR body itself notes Dependabot will re-propose 0.0.20+, which will break dependency resolution in every CI job again. Consider a one-line comment above these pins (and the ruff_python_stdlib pin in bashkit-monty-types/Cargo.toml), e.g. # ruff >0.0.15 requires rustc 1.97; held until the 1.96 toolchain pin is deliberately bumped.
Review summary (head
|
Same bumps as #2848 (fancy-regex 0.20, getrandom 0.4, hashbrown 0.17, itertools 0.15, speedate 0.18, strum 0.28) except ruff_python_* capped at 0.0.15: 0.0.16+ requires rustc 1.97 while the repo pins 1.96.0. Adapt to the bumps that change APIs: - fancy-regex 0.20: Captures gains an input-type parameter -> Captures<'_, str> - ruff 0.0.15: TokenKind::Name renamed to TokenKind::Identifier Supersedes #2848.
Dependabot would otherwise re-propose the unbuildable 0.0.16+ stream on the next cycle. Follows the wasmtime/oxc ignore precedent.
The toolchain action dropped its toolchain: input, so nightly jobs now install via run: rustup toolchain install nightly-.... The exempt-nightly detector only knew the legacy # nightly action-ref spelling and failed the migrated jobs (plus misclassified cargo-fuzz). Detect both; the discovery guard accepts either.
This reverts commit 00e95b4.
5dc86e0 to
1100401
Compare
| # The crates release in lockstep, so all six share one bound. Lift | ||
| # together with the toolchain; see the pin comments in | ||
| # crates/bashkit-monty/Cargo.toml and knowledge/operations/dependencies.md. | ||
| - dependency-name: "ruff_python_ast" |
There was a problem hiding this comment.
[P2] These six ignores are the only thing stopping Dependabot from re-proposing ruff 0.0.20+ (the exact failure that sank #2848), but unlike the analogous wasmtime hold, nothing tests that they survive. test_no_cargo_entry_can_propose_a_wasmtime_bump in scripts/tests/test_dependabot_coverage.py enforces the wasmtime ignore per cargo entry; a sibling test_no_cargo_entry_can_propose_a_ruff_bump asserting the six ruff_python_* names stay ignored for >=0.0.16 would give this hold the same protection. Without it, a future dependabot.yml tidy can silently drop these lines and the breakage only resurfaces as red CI on the next'Dependabot PR.
Exemption bumps for versions already exempted (jiff set, ruff 0.0.15 set, speedate 0.18, strum 0.28, unicode_names2 4.0); reviewed delta audits for signal-hook 0.4.5->0.4.6 (BorrowSignalSafe generalization), smallvec 1.16.0->1.16.4 (drop-check soundness fix), unicode-normalization 0.1.25->0.1.26 (Unicode 18 table regen + license metadata). cargo vet --locked passes locally.
|
This PR is obsolete — Every bump in this PR is to a crate only the Monty forks declare ( So the premise no longer holds either: capping The two API adaptations here are still needed and have landed with their own markers in #2876 ( Recommend closing. Leaving it to you rather than closing someone else's PR; nothing here is lost. Generated by Claude Code |
|
Closing as approved — obsolete, and nothing in it is lost. Every bump here was to a crate only the Monty forks declare ( The premise is gone too: capping The two API adaptations have landed with markers in #2876 ( Generated by Claude Code |
What changed
Same dependency bumps as #2848 (fancy-regex 0.20, getrandom 0.4, hashbrown 0.17, itertools 0.15, speedate 0.18, strum 0.28) except ruff_python_* capped at 0.0.15 instead of 0.0.20, plus two small API adaptations. Supersedes #2848.
Why
#2848 cannot land: ruff 0.0.16+ requires rustc 1.97 but the repo pins Rust 1.96.0 (
error: rustc 1.96.0 is not supported by ruff_python_ast@0.0.20 ...fails every CI job). Newest rustc-1.96-compatible ruff release is 0.0.15 (verified via crates.io metadata for all six crates).Before / After
Before (#2848): Lint and every downstream job fail at dependency resolution.
After:
cargo check --workspace --all-targets,cargo clippy -- -D warnings, andcargo test -p bashkit-monty(49 passed) all green locally; full matrix runs here.API adaptations (behavior-preserving):
Capturesgeneric over input type:Captures<'_>→Captures<'_, str>(2 call sites)TokenKind::Name→TokenKind::Identifier(1 site)Risk
Checklist
cargo check --workspace --all-targetsgreencargo clippy --workspace --all-targets -- -D warningsgreencargo test -p bashkit-montygreen (49 passed)Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.