Repository navigation
chore(deps): bump the example-cargo group across 2 directories with 2 updates - #2858
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 2f06c3e | Commit Preview URL Branch Preview URL |
Nov 07 2026, 01:58 PM |
| # no rebuild. `generate-import-lib` kept for the Windows abi3 import lib. | ||
| # See knowledge/runtimes/python-package.md § abi3. | ||
| pyo3 = { version = "0.29", features = ["extension-module", "generate-import-lib", "abi3-py39"] } | ||
| pyo3 = { version = "0.30", features = ["extension-module", "generate-import-lib", "abi3-py39"] } |
There was a problem hiding this comment.
[P0] pyo3 is bumped to 0.30 but pyo3-async-runtimes stays at 0.29, and the two must move in lockstep. pyo3-async-runtimes 0.29.x is built against pyo3 0.29 (pre-bump Cargo.lock resolves exactly one pyo3 0.29.3), so after this change the graph contains pyo3 0.29 and pyo3 0.30 side by side — and types from different versions of the same crate never unify. crates/bashkit-python inherits both from the workspace (crates/bashkit-python/Cargo.toml:20,44) and mixes them directly: async_bridge.rs:114-115 passes py: Python<'_> (now 0.30) into pyo3_async_runtimes::generic::get_current_locals, and lib.rs:83,94 aliases TaskLocals as CallerLoopLocals used with 0.30 PyObject/PyResult values. That is an E0308-style type mismatch and the crate will not compile. Fix: bump pyo3-async-runtimes to a 0.30-based release in the same change, or hold this bump until such a release exists.
| # no rebuild. `generate-import-lib` kept for the Windows abi3 import lib. | ||
| # See knowledge/runtimes/python-package.md § abi3. | ||
| pyo3 = { version = "0.29", features = ["extension-module", "generate-import-lib", "abi3-py39"] } | ||
| pyo3 = { version = "0.30", features = ["extension-module", "generate-import-lib", "abi3-py39"] } |
There was a problem hiding this comment.
[P1] The root Cargo.lock was not regenerated for this manifest change: it still pins pyo3 0.29.3 (verified in the head snapshot) and is not among the PR's changed files, even though the sibling random-fs and hyperlight lockfiles were updated. CI runs several cargo ... --locked steps (e.g. .github/workflows/ci.yml:429,432 plus cargo vet --locked), which fail when the tracked lockfile is out of date with the workspace manifests. Fix: re-resolve and commit the updated root lockfile (cargo update -p pyo3 / cargo check to refresh) — after resolving the P0 above, since a correct resolve is only possible once the companion crate is aligned.
Review summary — #2858 (dependabot pyo3 0.29→0.30 + wit-bindgen 0.62→0.63)Verdict: request changes (unchanged after rebase onto Findings (still open)
Context read beyond the diff (this push): refreshed snapshot at head Could not review: no build/test run possible here (reasoned from code only); registry state of a |
|
Superseded by #2852 - this bump cannot land alone: pyo3 0.30 collides on links=pyo3-python with jiter 0.17's pyo3 0.29 (and pyo3-async-runtimes 0.29), so resolution fails in every rust job. #2852 keeps your bumps and adds the required companions (jiter 0.18, pyo3-async-runtimes 0.30, whose required pyo3 deps move to ^0.30), removes the 8 now-deprecated skip_from_py_object options, and bumps the vet exemptions. Close this once #2852 lands. |
d9cd090 to
2344ea1
Compare
|
Analysed — this cannot merge as proposed, and #2876 + #2863 carry its content. pyo3 0.30 here collides with jiter 0.17's pyo3 0.29 on Landing pyo3 0.30 needs the companions the jump requires — jiter 0.18 (whose required pyo3 moves to ^0.30.1) and pyo3-async-runtimes 0.30 — which #2863 has. #2863 was itself blocked: jiter is declared in
Closing once #2863 lands. Generated by Claude Code |
… updates Bumps the example-cargo group with 1 update in the /crates/bashkit-python/test-fixtures/random-fs directory: [pyo3](https://github.com/pyo3/pyo3). Bumps the example-cargo group with 1 update in the /examples/hyperlight directory: [wit-bindgen](https://github.com/bytecodealliance/wit-bindgen). Updates `pyo3` from 0.29.3 to 0.30.1 - [Release notes](https://github.com/pyo3/pyo3/releases) - [Changelog](https://github.com/PyO3/pyo3/blob/v0.30.1/CHANGELOG.md) - [Commits](PyO3/pyo3@v0.29.3...v0.30.1) Updates `wit-bindgen` from 0.62.0 to 0.63.0 - [Release notes](https://github.com/bytecodealliance/wit-bindgen/releases) - [Commits](bytecodealliance/wit-bindgen@v0.62.0...v0.63.0) --- updated-dependencies: - dependency-name: pyo3 dependency-version: 0.30.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: example-cargo - dependency-name: wit-bindgen dependency-version: 0.63.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: example-cargo ... Signed-off-by: dependabot[bot] <support@github.com>
2344ea1 to
2f06c3e
Compare
pyo3 0.29 -> 0.30 and pyo3-async-runtimes 0.29 -> 0.30, plus the companions the jump requires: jiter 0.17 -> 0.18 in bashkit-monty, syn 2 -> 3 in the random-fs fixture, and hyperlight/wit-bindgen in the example. Cargo.lock now holds a single pyo3 (0.30.1). pyo3 0.29's jiter and pyo3 0.30 collide on links=pyo3-python, so resolution failed in every rust job until jiter moved; 0.18 is the smallest release whose required pyo3 is ^0.30.1. That bump edits a Monty fork manifest, which the drift check rejects unless marked, so the jiter line carries a `bashkit fork:` note recording why it sits ahead of upstream's 0.17. pyo3 0.30 made `skip_from_py_object` the default and removed the `FromPyObject for T: PyClass + Clone` blanket impl, so the 8 occurrences of the option are dropped as behavior-preserving rather than silently changing extraction. Supersedes #2858. 52 checks green, including the pytest matrix (3.9-3.14) and the CPython jobs that are the real validation for an FFI major.
|
Closing: this PR's content landed in #2863 (squashed as pyo3 0.30 here collided with jiter 0.17's pyo3 ^0.29.2 on That jiter bump edits a Monty fork manifest, which the drift check from #2861 rejects, so it needed the marker mechanism added in #2876 first. The chain was #2876 → #2863. Also carried from here: 52 checks green on #2863, including the pytest matrix (3.9–3.14) and the CPython jobs, which are the real validation for a pyo3 major. Generated by Claude Code |
Bumps the example-cargo group with 1 update in the /crates/bashkit-python/test-fixtures/random-fs directory: pyo3.
Bumps the example-cargo group with 1 update in the /examples/hyperlight directory: wit-bindgen.
Updates
pyo3from 0.29.3 to 0.30.1Release notes
Sourced from pyo3's releases.
... (truncated)
Changelog
Sourced from pyo3's changelog.
... (truncated)
Commits
f168538release: 0.30.1b3c7361pyo3-introspection sdist: skip maturin license lookup (#6528)b564d8cci: requireCargo.lockto be up to date during testing (#6522)bbd862csupport PyPy 3.12 (#6448)196ca35release: 0.30.0 (#6493)d3befaaremove all functionality deprecated in PyO3 0.28 (#6519)3ee4e56experimental-inspect: emit__all__in the generated stubs (#6242)071edectest against 3.15 final (#6517)4c68d9cinternal: remove no longer needednon_local_definitionsallows (#6508)65c8c7dAdd example building withmeson-python(#6483)Updates
wit-bindgenfrom 0.62.0 to 0.63.0Commits
29e0393Release wit-bindgen 0.63.0 (#1748)99dab3bUpdate wasm-tools dependencies (#1749)1559c82Don't cancel spawned rust tasks on component task cancel (#1743)3e8e729rust: preserve WASIp3 TLS for no-std task context (#1745)1145d46rust: Suppress wake notifications while destroying async tasks (#1740)673e9d5feat(moonbit): migrate generated manifests to modern formats (#1741)ac8ff51Replace--asyncwith--sync(#1730)e9590b4chore: bump go-pkg version (#1738)83d497fExport the versionedcabi_reallocon native targets (#1736)687dbb8Fix non-determinism in the order ofwithremappings (#1737)Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.