Repository navigation
fix(python): mark the Monty fork edits that turned main red - #2865
Merged
Merged
Conversation
Review verdict: approve — comment-only markers plus a correct checker fix, no behavior changeNo findings. This PR does exactly what it says: marks the 11 unmarked #2857 fork edits so the #2861 drift check passes, and fixes the checker's blind spot for markers at the top of long attached comment blocks. What I verified beyond the diff:
Update on re-review (head |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | b241d7f | Commit Preview URL Branch Preview URL |
Nov 06 2026, 09:53 AM |
The drift check (#2861) was cut from a branch that predated the shared-graph fix (#2857), so each passed its own CI and main went red on 12 unmarked regions once both landed. Eleven are real #2857 edits and are now marked: eight `repr_check_time(..)?` call sites (dict x2, generic_alias, union, partial x2, list x2), the `ResourceError` import the error-returning check needs, the `write_dataclass_repr` doc sentence, and the `tick` initializer. Each call site only gained `?`, so its marker points at the shared rationale on `repr_check_time` rather than repeating it. The twelfth was a checker blind spot: the fixed three-line window read the tail of a multi-line fork note and missed the marker on the note's first line, which is how these forks are written (`repr_check_time`'s note runs eleven lines). The window now covers the whole comment/attribute block attached to the changed item and stops at the first line of code, so one item's note cannot mark the next item's drift. Rust source is unchanged apart from comments. Claude-Session: https://claude.ai/code/session_01Wy7MBvvcpUtMeYF4j5LgpF
chaliy
force-pushed
the
eve/clever-mccarthy-7qwnvu
branch
from
November 6, 2026 09:53
b7ed794 to
b241d7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
mainis green again. The Monty fork drift check passes, and the two causes behind the 12 reported regions are fixed:repr_check_time(..)?call sites (dict×2,generic_alias,union,partial×2,list×2), theResourceErrorimport the error-returning check needs, thewrite_dataclass_reprdoc sentence, and thetickfield initializer. Each call site only gained a?, so its marker points at the shared rationale onrepr_check_timeinstead of repeating eleven lines of it eight times.repr_check_time's note runs eleven lines,check_time_every's five). The window now also covers the whole comment/attribute block attached to the changed item, and stops at the first line of code so one item's note cannot vouch for the next item's drift.Rust source changes are comments only; no behavior change.
Why
The drift check landed in #2861 from a branch cut before #2857 merged. Each PR was green on its own branch, and
mainwent red the moment both were in it — the check had never seen #2857's edits, and #2857 had never seen the check. Red since 05:29 UTC today.Before / After
Before, on
main@7789381:After:
Also verified locally:
The three new checker tests reproduce the real shape (a fork note inserted into an unchanged doc block, plus a signature change below it, as two separate diff hunks). Confirmed each fails against the old fixed-window rule before the fix, and that a note still cannot reach past a line of code into the next item.
Risk
test_comment_block_does_not_reach_past_codeandtest_marker_far_above_does_not_cover_change). Rust edits are comment-only, so no runtime behavior moves.Checklist
https://claude.ai/code/session_01Wy7MBvvcpUtMeYF4j5LgpF