Repository navigation
chore(deps): bump russh to 0.65.1 and signal-hook to 0.4.6 - #2886
Conversation
Completes #2880. Both are recorded as cargo-vet exemptions rather than delta audits. The two crates sit on delta-audit chains (russh 0.63.3 -> 0.64.1 -> 0.65.0, signal-hook 0.4.4 -> 0.4.5) whose entries are human source-safety reviews, so `cargo vet --locked` reported them unvetted after the bump and the Audit job failed. The owner approved taking the bumps without new reviews, which is what an exemption records: accepted, not audited. Writing an audit entry instead would assert a source review that nobody performed. So the chains stop at 0.65.0 and 0.4.5; these versions are covered by exemption. A later `cargo vet certify` of the 0.65.0 -> 0.65.1 and 0.4.5 -> 0.4.6 deltas can replace the exemptions and restore the audited chain, and `cargo vet prune` will then drop them as unnecessary. Also drops untrusted 0.7.1, which nothing in the graph needs any more. Verified: cargo vet --locked clean, cargo check --workspace --all-targets clean, 24 ssh builtin tests (russh), 152 bashkit-cli tests (signal-hook), 263 repo-script tests. Claude-Session: https://claude.ai/code/session_01Wy7MByvAMwapenBYpmq9HN
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 2835832 | Commit Preview URL Branch Preview URL |
Nov 07 2026, 05:01 PM |
Review summary — chore(deps): bump russh to 0.65.1 and signal-hook to 0.4.6Verdict: No findings; no review submitted. This is a routine patch-level dependency bump (russh 0.65.0 → 0.65.1, signal-hook 0.4.5 → 0.4.6) with no source-code changes. Findings by severity: None (no P0/P1/P2). What I checked beyond the diff:
Notes (non-blocking):
|
|
Thanks — the subtree coverage check is the useful part, since that was the thing I could not verify by inspection alone. Two notes back. On the file list: there is no
On the superseded exemptions ( They are the roots of the delta-audit chains: So they stay until the deltas are certified; Agreed on everything else, including Generated by Claude Code |
What changed
russh0.65.0 → 0.65.1 andsignal-hook0.4.5 → 0.4.6, recorded as cargo-vet exemptions rather than delta audits. Completes #2880 (itstoml/toml_writerhalf landed in #2884).Also drops
untrusted0.7.1, which nothing in the graph needs any more.Why exemptions and not audits
Both crates sit on delta-audit chains whose entries are human source-safety reviews:
russh:0.63.3 → 0.64.1 → 0.65.0signal-hook:0.4.4 → 0.4.5So after the bump
cargo vet --lockedreported both unvetted and theAuditjob failed. You approved taking the bumps without new reviews, and an exemption is precisely what records that: accepted, not audited. An audit entry would instead assert that a source review happened — it didn't, and writing one under your name would be a false attestation in the mechanism that exists to prevent exactly that.The practical consequence, stated plainly: the audited chains now stop at
0.65.0/0.4.5, and these two versions are covered by exemption instead. If you later want them audited,cargo vet certifyof the0.65.0 → 0.65.1and0.4.5 → 0.4.6deltas replaces the exemptions, andcargo vet prunewill drop them as unnecessary at that point.Before / After
partially auditeddrops 81 → 79 because these two versions no longer resolve through their delta chains — the visible trace of the audited→exempt swap above.Risk
russhis an SSH implementation reached over the network, and this version is now accepted without a source review. That is the trade-off you approved; it is recorded inconfig.tomlwherecargo vetsurfaces it, not hidden.Eugeny,vorner).russh), 152bashkit-clitests (signal-hook, interactive), 263 repo-script tests,cargo check --workspace --all-targetsclean,cargo vet --lockedclean.Checklist
cargo vet --lockedpasses (reproduced the failure first)Closes #2880.
Generated by Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.