Repository navigation
perf: hand over per-page SVG bytes without copying - #55
Merged
Merged
Conversation
typst_svg::svg returns an owned String, so its bytes can be moved into the output buffer instead of copied, matching the merged-SVG path.
msallin
force-pushed
the
perf/svg-page-copy
branch
from
October 17, 2026 09:10
dcee164 to
26d20b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-page SVG export copied each page's markup into a new
Vecwithsvg.as_bytes().to_vec().typst_svg::svgalready returns an ownedString, so its bytes are now moved into the buffer withinto_bytes(), the way the merged-SVG path already does. That is one allocation and one copy fewer per page.Behaviour is unchanged and the existing
plain_svg_still_produces_one_image_per_pagetest covers this path.cargo test --releasepasses.