Skip to content

Memory-claim check cuts a sentence at the period in "Dr." #554

Open

Description

@itsskofficial

Found while testing #553. memory_claim in sentient/agent/outcomes.py splits a reply into sentences on periods, so "I've saved that your dentist is Dr. Mehta" is cut to "...your dentist is Dr." and the name is lost. With memory on, the stored-memory comparison then sees too little: "your dentist is Dr. Mehta" goes uncorrected even when the stored dentist is Dr. Kulkarni and nothing was saved in that turn.

Fix: don't end a sentence at common abbreviations (Dr., Mr., Mrs., Ms., St., e.g., i.e., a.m., p.m.) or at a period inside a name or number. #495 handles similar dotted words, so look there for a shared approach if it has landed.

Done when: a test shows "I've saved that your dentist is Dr. Mehta" keeps the whole claim and is corrected when only a different dentist is stored and nothing was saved, and a claim backed by a stored memory is still left alone.

Activity

  1. added
    bugSomething isn't working
    area: engineAgent loop, models, approvals, storage, gateway
    area: memoryFacts, user model, nightly consolidation
    priority: P2Later: useful, lower urgency
    size: SSmall: a few days
    on Nov 8, 2026
  2. G26karthik commented on Nov 8, 2026

    @G26karthik
    Contributor

    /assign

  3. github-actions commented on Nov 8, 2026

    @github-actions

    @G26karthik Assigned to you. Open a PR within a week or comment if you need more time.

  4. added 2 commits that reference this issue on Nov 8, 2026
    7c33248
    c799443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area: engineAgent loop, models, approvals, storage, gatewayarea: memoryFacts, user model, nightly consolidationbugSomething isn't workinggood first issueGood for newcomerspriority: P2Later: useful, lower urgencysize: SSmall: a few days

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions