Repository navigation
Conversation
GitHub rejects a duplicate in-flight reservation with 409 already_exists. The server returned 200 with `ok: false`, so clients such as BuildKit's gha cache could not tell a duplicate from a failure. `createUpload()` now throws AlreadyExistsError, which maps to a 409 response. Fixes falcondev-oss#276
pcmxgti
commented
Oct 18, 2026
| .select('id') | ||
| .executeTakeFirst() | ||
| if (existingUpload) return | ||
| if (existingUpload) throw new AlreadyExistsError('upload') |
Author
There was a problem hiding this comment.
Here I could have just checked an empty return, but felt like a brittle check if there are more checks added to createUpload() later on. I took the liberty of creating a new error class.
I can always go back to just checking an empty return if you think that's more aligned with the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub rejects a duplicate in-flight reservation with 409 already_exists. The server returned 200 with
ok: false, so clients such as BuildKit's gha cache could not tell a duplicate from a failure.createUpload()now throws AlreadyExistsError, which maps to a 409 response.Fixes #276