Packages (macOS): adds pkgsrc detection - #2629
Open
Saadanjum0 wants to merge 1 commit into
Open
Saadanjum0 wants to merge 1 commit into
Saadanjum0 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the report in #2587.
Problem: pkgsrc packages are never counted on macOS, even though the
pkgsrcpackage manager is supported on NetBSD, Linux and SunOS.Cause:
packages_apple.chas noPKGSRCbranch.Fix: count the entries in
/opt/pkg/pkgdb, the default pkgsrc bootstrap prefix on macOS, the same way the NetBSD implementation does for/usr/pkg/pkgdb. Also adds a changelog entry.Testing: built on macOS (arm64) with the project's CMake setup, the build succeeds and
fastfetchruns normally. On a machine without/opt/pkgthe count stays 0 and the module output is unchanged. I have not verified against a real pkgsrc install on macOS.