Repository navigation
Fix OneHotEncoder metadata dropping generated indicators (#1106) - #1107
Open
avinashtrivedix wants to merge 3 commits into
Open
avinashtrivedix wants to merge 3 commits into
avinashtrivedix wants to merge 3 commits into
Conversation
Author
|
I noticed the Python 3.9 pipeline is failing due to _SklearnCheckInputWrapper exceptions across unrelated modules (test_time_series, test_imputation, etc.). Since the style checks are green and the test_onehot_encoder.py suite passed successfully on the 3.10 and 3.11 runners, this appears to be a separate upstream environment issue on main. Let me know if you need any adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1106
Description
This PR resolves a metadata omission bug in
OneHotEncoderwhere newly generated dummy columns were inadvertently dropped if their generated names collided with the original categorical input column names.Changes Made
_add_new_feature_names()infeature_engine/encoding/one_hot.py.transform()method untouched, respecting the architectural updates already pending in thenarwhals-migrationbranch.Testing
pytest tests/test_encoding/test_onehot_encoder.py); all 29 tests pass successfully against the currentmainbranch.