Repository navigation
Web UI: fix JS SyntaxError that stopped the whole page from running - #17
Merged
Merged
Conversation
The embedded page was a non-raw Python string, so split('\n') rendered as a
real newline inside a JS string literal. Make it a raw string and test that
the served script parses.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The built-in Web UI (
opendrop serve, then open/) did nothing at all. Loading it headless in Chromium showedPAGEERR Invalid or unexpected token: the model list never loaded, the hardware badge stayed on "Loading hardware…", and Send/Pull were inert.Root cause:
_WEB_UIinopendrop/ui/web.pyis a normal (non-raw) triple-quoted Python string, so the twobuf.split(' ')/chunk.split(' ')calls are served with a literal newline inside a JS string literal.node --checkon the served script:SyntaxError: Invalid or unexpected tokenat line 120. The check in #16 ran against the source text, not the rendered page, so it missed this.Fix
_WEB_UI = r"""...""". Those twoEvidence
/favicon.ico404.)tests/test_web_ui.py: checks the escape survives and runsnode --checkon the served script (skipped if node is absent). Both fail onmain, pass here. Full suite: 180 passed.No version bump/release:
publish.ymlpublishes to PyPI asopendrop, a name owned by another project (owner decision pending).