Repository navigation
Webhook-Ports kontrolliert validieren - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was & warum
Webhook-URLs mit nicht numerischen oder außerhalb des gültigen Bereichs liegenden Ports konnten beim Zugriff auf
urlparse().porteine roheValueErrorauslösen. Außerdem wurde für HTTP-URLs ohne Port bislang Port 443 zur DNS-Auflösung verwendet. Die Eingabevalidierung behandelt beide Fälle nun vorhersehbar und protokollgerecht.Änderungen
UnsafeWebhookURLErrorabgelehnt.Getestet
python -m compileall -q app tests– erfolgreichruff check app tests --select E9,F63,F7,F82– erfolgreichSCAN2TARGET_REQUIRE_AUTH=true pytest -q– 29 Tests bestandennpm test– 3 Tests bestandennpm run check– 0 Fehler, 0 WarnungenReview-Hinweise
Bitte insbesondere prüfen, ob das Ablehnen syntaktisch ungültiger Ports auch bei aktivierten privaten Webhooks dem gewünschten Verhalten entspricht. Das Risiko ist gering und auf die Webhook-Eingabevalidierung begrenzt.