Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigen-state
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
{
"version": "1",
"algorithm": "sha256",
"generated_at": "2026-10-29T15:57:26.956791Z",
"generated_at": "2026-11-09T23:09:20.862721Z",
"spec_files": {
"resources/account-data-api.yaml": "ca145d50d48e0f3709130af89cf0feb3416c36adbd54b5ad40740f55217f94af",
"resources/auth-api.yaml": "01e54ca1a13d2d6307e0d3a9ea38f816902521e7c85998f0f21a1353cc54fb76",
"resources/bluefin-api.yaml": "27c095db0279a96408e4b60840d791c344fd40a380d4edb3bbf1f68b68ff7f2d",
"resources/common.yaml": "760ce6c130e31c3f0eafd692ca5d834499c7f24a15157fb4b43d05bd1043a0c0",
"resources/common.yaml": "c988ec664a55450806c8ee838c7d787e38c2d5af74287e58b949315fd5457be7",
"resources/exchange-common-api.yaml": "3c84fcdfa44e689c2465b79dab3dd0d2a2a1777ad207e167c64c457fcba58006",
"resources/exchange-pro-api.yaml": "a9b065f87a8c5992667eee65f3680f178de693f0a01c82726f0378547a2b540f",
"resources/rewards-data-api.yaml": "cdbd81ff161c09bf47ac6099e892d1f1e6a735d035cb16a22d6ad7eec0ac3550",
"resources/trade-api.yaml": "229ac3d9a7a30b640db928cc5d99cddc4e185e70b76e7c0d7273f94225cd1d37",
"resources/trade-api.yaml": "7256f14398f76f06fab31cd477386a7e0f4ec960c17e841dc100a2676d8a5d5f",
"resources/vera-api.yaml": "f4c51b5f6614dd4e3b9f5f1f01f945e06d9090849530ecb916ad4ae18d8f61a0",
"resources/websocket-api.yaml": "ff3458af8e3788bf0ae94159a60b0964186bed574aa4ec1edac70fae9d25c06a"
},
"combined_hash": "13e2104bd6fe752d0cf6d120281300f3f3c00fe4a88005ba17ad1c8f6ac2a7dd"
"combined_hash": "984fcd9f9b8f481315e1d4733eba220a1060280e2a00ed78f6bbfcda499eccd9"
}
2 changes: 1 addition & 1 deletion python/sdk/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ additionalProperties:
library: asyncio
generateSourceCodeOnly: true
useOneOfDiscriminatorLookup: true
packageVersion: 1.22.0
packageVersion: 1.23.0
2 changes: 1 addition & 1 deletion python/sdk/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ description = "Python Boilerplate contains all the boilerplate you need to creat
name = "bluefin_pro_sdk"
readme = "README.rst"
requires-python = ">=3.9.2,<3.14.0"
version = "1.22.0"
version = "1.23.0"

[[project.authors]]
email = "audreyr@example.com"
Expand Down
2 changes: 1 addition & 1 deletion python/sdk/src/openapi_client/__init__.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion python/sdk/src/openapi_client/api_client.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion python/sdk/src/openapi_client/configuration.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion python/sdk/src/openapi_client/docs/Asset.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion python/sdk/src/openapi_client/models/asset.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion python/sdk/src/openapi_client_README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion resources/common.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,10 @@ components:
description: "The effective balance of the asset."
maxWithdrawQuantityE9:
type: string
description: "The maximum quantity that can be withdrawn."
description: >-
The maximum quantity that can be withdrawn, in e9. It is not rounded to the
asset's on-chain decimals; round it down to a multiple of 10^(9 - decimals)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10^(9 - decimals) only holds for decimals <= 9. The engine uses 10u64.pow(9_u32.saturating_sub(decimals)), so for any asset with more than 9 decimals the quantum is 1. A client that follows the formula literally gets a fractional or negative exponent (10 ** (9 - 18) -> 1e-9, or a BigInt RangeError). Consider saying "10^max(0, 9 - decimals)" here and on amountE9.

(1000 for USDC) before using it as a withdrawal amount.
updatedAtMillis:
type: integer
format: int64
Expand Down
8 changes: 7 additions & 1 deletion resources/trade-api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,13 @@ components:
example: 0x000000000ABC
amountE9:
type: string
description: The amount in e9 of the asset that the User will withdraw from their account
description: >-
The amount in e9 of the asset that the User will withdraw from their account.
Must be a whole number of the asset's smallest on-chain unit, i.e. a multiple of
10^(9 - decimals) where decimals is the asset's on-chain decimals (1000 for USDC,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the asset's on-chain decimals" doesn't say where a client gets that value. The only exposed field is AssetConfig.decimals in exchange-pro-api.yaml:116, and its description is "Default precision for rendering this asset." That reads as a UI precision, not the on-chain unit used for this check. A client could reasonably compute the quantum from some other source. Please point to ExchangeInfo.assets[].decimals here, and update the AssetConfig.decimals description to say it is the on-chain decimals the withdrawal quantum is based on.

which has 6 decimals). Other amounts are rejected after the request is accepted,
via a failed-command event. Round down to that multiple before submitting,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"via a failed-command event" leaves out what integrators need to match on. pro-mono#2125 maps Error::WithdrawPrecision to CommandFailedReason::WithdrawZero, so a non-zero amount like 1,500 comes back as AccountCommandFailureUpdate { failedCommandTypeCode: WITHDRAW, reasonCode: WITHDRAW_ZERO }. A client that handles WITHDRAW_ZERO as "you sent 0" will show the wrong cause. Either document that WITHDRAW_ZERO also covers precision failures (here and on CommandFailureReasonCode in websocket-api.yaml), or add a dedicated reason code in both repos.

including when withdrawing maxWithdrawQuantityE9.
example: 1000000000
salt:
type: string
Expand Down
4 changes: 2 additions & 2 deletions rust/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions rust/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ sha2 = "0.10.9"

[dependencies.bluefin_api]
path = "gen/bluefin_api"
version = "1.22.0"
version = "1.23.0"

[dependencies.ed25519-dalek]
features = ["rand_core"]
Expand Down Expand Up @@ -93,7 +93,7 @@ keywords = [
license = "Unlicense"
name = "bluefin-pro"
repository = "https://github.com/fireflyprotocol/pro-sdk"
version = "1.22.0"
version = "1.23.0"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version goes to 1.23.0 here and in rust/gen/bluefin_api/Cargo.toml, but rust/Cargo.lock still pins bluefin-pro and bluefin_api at 1.22.0. Earlier bumps updated it (972f367, 2628568). cargo metadata --locked in rust/ already fails on this branch (exit 101). Any --locked/--frozen build fails, and a plain cargo build rewrites the lockfile and leaves the tree dirty. That can also block cargo publish --workspace in crates_publish.yaml. Please commit the regenerated Cargo.lock.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in e56ccfd: refreshed rust/Cargo.lock with cargo update --workspace, so bluefin-pro and bluefin_api are locked at 1.23.0 (cargo metadata --locked passes). apigen's version bump doesn't touch the lockfile.


[workspace]
members = [
Expand Down
2 changes: 1 addition & 1 deletion rust/gen/bluefin_api/Cargo.toml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rust/gen/bluefin_api/README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rust/gen/bluefin_api/docs/Asset.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rust/gen/bluefin_api/docs/WithdrawRequestSignedFields.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rust/gen/bluefin_api/src/models/asset.rs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rust/gen/config.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ts/sdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,5 @@
},
"type": "module",
"types": "./dist/index.d.ts",
"version": "2.4.0"
"version": "2.5.0"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says this version was set by hand because apigen would have moved TS back to 1.23.0. bump_all_versions takes the base version from rust/Cargo.toml and writes it to ts/sdk/package.json. ts/sdk/openapitools.json npmVersion is also stuck at 1.16.0. So every spec change needs the same manual TS fix, and one missed fix publishes a lower version than 2.5.0, which npm rejects or which looks like a downgrade. It would be more robust to fix this in apigen: give TS its own base version read from package.json, or a fixed major offset, instead of overriding the output by hand each release.

}
4 changes: 2 additions & 2 deletions ts/sdk/src/api.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ts/sdk/src/docs/Asset.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ts/sdk/src/docs/WithdrawRequestSignedFields.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading