Repository navigation
fix(ios): make podspec webrtc path relative - #2
Merged
Magmusacy merged 1 commit intoNov 12, 2026
Merged
Conversation
The absolute webrtc path in HEADER_SEARCH_PATHS went into the evaluated podspec, so the Podfile.lock checksum was different in each checkout and pod install left the lock file modified. Anchor the path on PODS_TARGET_SRCROOT. Keep symlinks in __dir__, because Xcode collapses ".." as text.
Magmusacy
self-requested a review
November 12, 2026 12:36
Magmusacy
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The podspec resolves
@fishjam-cloud/react-native-webrtcwithnodeand wrote the absolute directory intoHEADER_SEARCH_PATHS.CocoaPods writes the evaluated podspec to
Pods/Local Podspecs/FishjamReactNativeWorklets.podspec.json, and theSPEC CHECKSUMSentry inPodfile.lockis the SHA-1 of that file.Thus each machine, worktree and CI runner got a different checksum, and
pod installleftPodfile.lockmodified in each app that uses this packageChange
The
noderesolution stays, because the package can be hoisted.The result is now relative to the pod directory and starts at
$(PODS_TARGET_SRCROOT):