Repository navigation
fix: don't crash on a licence that isn't an SPDX identifier - #64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: no issue.
Changes proposed in this pull request:
Every command that uses the extension scaffolder (
infra,upgrade, …) loads the SPDX text for thelicenseincomposer.json. Anything other than a known SPDX ID or exactlyproprietarymade it throwCannot find module, e.g."© Glowing Blue AG"or"PROPRIETARY". Licences are now matched against the SPDX list ignoring case, and any other value gives an empty licence text.Reviewers should focus on:
Screenshot
N/A
Necessity
Confirmed
infra editorConfigon a copy of an extension with a free-form licence.)yarn testinjs/).composer test). (N/A)