Repository navigation
fix(upgrade): generate valid PHP for an API resource without a model - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51
Changes proposed in this pull request:
When the JSON:API step can't link a serializer to a model, it generates a resource on
AbstractResource. That resource always gotimplements, even with no interfaces after it, because the template'sifhad no braces. The invalid PHP then crashed the next step's parser. A resource with no model also lost the comma afterEndpoint\Create::make(), and the stub'sindexendpoint choice returned a value the template never checks.Reviewers should focus on:
query(),find(), …). It parses now, but needs those methods written by hand, as the upgrade guide already says.Screenshot
N/A
Necessity
Confirmed
upgrade 2.0to the end on the reporter's 1.x code.)yarn testinjs/).composer test). (N/A)