Repository navigation
feat(upgrade): report each step's outcome as JSON for a program driving the upgrade - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: no issue.
Changes proposed in this pull request:
upgrade 2.0 --jsonlets another program, such as an AI agent, drive the upgrade. It asks nothing (it implies-n) and prints one JSON object when it finishes, exiting non-zero if the upgrade didn't complete. For each step the object gives its status (committed,no-changes,skipped,failedornot-run). A committed step adds its commit, its manual-work notes and the@TODOs its commit added. A failed step lists the files it couldn't upgrade, each with the reason. Errors from before any step come back in the same shape.Without
--json, output that isn't going to a terminal no longer has cursor codes or spinner lines. The API resource stub's@todois now@TODO, like every other marker, and a strayconsole.login the frontend misc step is gone because it would break the JSON. The README now documentsupgrade.Reviewers should focus on:
Screenshot
N/A
Necessity
Confirmed
upgrade 2.0 --jsonon a real 1.x extension.)yarn testinjs/).composer test). (N/A)