Repository navigation
fix(upgrade): correct what a real 1.x extension's upgrade got wrong, and add --check - #67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: no issue.
Changes proposed in this pull request:
Upgrading ianm/gravatar showed what the 2.0 upgrade still gets wrong. It no longer lowers a version an extension already asks for, and JSON files keep their newline and indentation. Build tooling moves to
devDependencies, and the typings scripts the 2.x frontend workflow runs are added.tsconfig.jsonreads every vendor package's global typings and sets"types": [], because TypeScript 4.9 can't parse the@types/nodewebpack brings along. The skeleton gets the same tsconfig change.main_git_branchmoves to2.xwhen there is a 2.x branch, and gets a@TODOwhen there isn't. The JSON:API step no longer adds unused imports, and added imports are sorted. An admin initializer the step has emptied is removed. Work the upgrade can only point out, such as the AvatarEditor andavatarSrcsetchanges, is listed in the--jsontodos.upgrade 2.0 --checkreports what the upgrade would change without changing anything. The steps run on the last commit, in a temporary worktree. Running it on already-upgraded extensions turned up steps that break 2.x code, now fixed:AlertableInterfacewas added twice;LabelValueandLoadingPostaren't lazy any more;Reviewers should focus on:
--checkcreates and removes a git worktree and branch in the extension's repository.Screenshot
N/A
Necessity
Confirmed
yarn testinjs/).composer test).