Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets around an issue with using
tokio::spawn_blockingfor starting synchronous attestation generation tasks from the async runtime.This issue is we can't add a timeout to these, but we do add an overall timeout to connections. The danger is, that is the quote generation task hangs, and the corresponding connection task gets killed, the generation task is left running. These could mount up indefinately causing resource exhaustion.
This PR introduces a limit on the number of these tasks we can have (currently 16). This means we may end up blocked by a hung tasks but we can never keep creating them indefinitely.