Repository navigation
test(session): cover invoke replies after control removal - #7028
Closed
mayuriphad wants to merge 1 commit into
Closed
mayuriphad wants to merge 1 commit into
mayuriphad wants to merge 1 commit into
Conversation
|
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Adapt the removed-control regression tests to flet-1.1.0, which already resolves pending calls without terminating the receive loop. Preserve successful replies and client errors after a mounted control is removed, and verify that a subsequent invocation still completes. Record issue flet-dev#6941 and PR flet-dev#7028 in the existing 1.1.0 changelog entry.
FeodorFitsner
force-pushed
the
fix/invoke-reply-removed-control
branch
from
October 31, 2026 19:35
ab653b9 to
6efe2ab
Compare
FeodorFitsner
changed the title
Contributor
|
Thanks for the contribution! This issue is already fixed on The existing implementation resolves pending calls even after control removal, preserving the client’s result or error without terminating the session. Closing this PR as already addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6941
Late client-method replies must resolve their pending call after the target control is removed without interrupting the session. Add regression tests for successful and error replies after actual control removal, unmatched replies, and replies for registered controls. The removal cases also verify that a subsequent invocation completes.
The
flet-1.1.0implementation already handles these replies, including preserving successful results. Keep that behavior and add the issue, PR link, and contributor credit to the existing 1.1.0 changelog entry.Validation: all 4 focused pytest cases pass;
ruff checkandruff format --checkpass.