Skip to content

feat: pull request metadata contract and additive schema 12 - #114

Merged
flexdinesh merged 1 commit into
mainfrom
github-pr-contract
Oct 25, 2026
Merged

flexdinesh merged 1 commit into
mainfrom
github-pr-contract

Conversation

@flexdinesh

@flexdinesh flexdinesh commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

Stack 1/4: GitHub pull requests on diffx-server. Live GitHub testing is pending; see docs/github-live-testing.md (layer 4).

  • Behavior owner and resulting change: ingestion adds optional metadata.pullRequest (author, title, body, state, draft, refs, times) and reserved github source/trigger. reviewstore projects the stream head's winning submission's pullRequest onto the head context, like activity.
  • Contracts/invariants affected; local/remote implications: Protocol stays 4. Public ingestion (collector/API tokens) rejects pullRequest, the github source and the github trigger with 400; only the server's GitHub integration may author them. Schema 11 → 12 is additive (CREATE-only); older-than-11 state still refuses. No local-mode behavior change.
  • Validation results; remaining risks: mise run check passes. Real-binary check: schema 11 DB upgrades to 12 in place, producer-claimed PR gets 400. Projection test covers metadata-only edits, late submissions and new pushes. Risk: first additive migration sets precedent.
  • Intentional architecture/design changes and rationale: additive schema policy (additiveSchema = 11) documented in docs/architecture.md and docs/release.md.
  • UI evidence: n/a.

- optional protocol 4 metadata.pullRequest, server-authored only
- public ingestion rejects github source, trigger and pullRequest
- current heads project winning submission's pullRequest
- schema 11 upgrades in place to 12 (additive-only policy)
@flexdinesh
flexdinesh added this pull request to stack #118 October 25, 2026 05:19
@flexdinesh flexdinesh changed the title github pr contract feat: pull request metadata contract and additive schema 12 Oct 25, 2026
@flexdinesh
flexdinesh marked this pull request as ready for review October 25, 2026 06:32
@flexdinesh
flexdinesh merged commit dde7f81 into main Oct 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant