Repository navigation
feat: GitHub pull requests in Settings, Reviews column and diff banner - #117
Merged
Merged
Conversation
Settings connects GitHub, follows repositories and resyncs; pull request rows show #N title, GitHub and author, and leave the column once closed or merged; a collapsible banner shows state, branches, a GitHub link and the description as sanitized Markdown. Adds LinkButton and MarkdownText, a GitHub setup guide, and docs/github-live-testing.md for checks pending a real GitHub App.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 4/4: GitHub pull requests in the web app, user guide, and pending live-test note.
account-github.tsx(Settings: Connect, install link, follow checkboxes, Resync, Disconnect, callback outcome; absent when the server returns 404).project-nav.ts: PR rows show#N title,GitHub · @author, PR/draft icon; closed and merged PRs leave the Reviews column (still searchable).PullRequestBanner.tsx: collapsible banner above the diff with state badge, author, head → base, Open on GitHub, description. New compositesMarkdownText(react-markdown + remark-gfm: raw HTML skipped, unsafe URLs stripped, images as links) andLinkButton(link semantics, button visuals).observation.pullRequest; no API change. Local mode unaffected.mise run checkpasses (122 browser tests). New browser tests: Settings absent/connect (CSRF, callback message cleared)/follow+resync/expired+disconnect; PR row + banner + sanitization (fails ifskipHtmlis removed). Unit tests for PR nav rules (fail if the closed/merged filter is removed). Live GitHub testing pending:docs/github-live-testing.md.DESIGN.mddocuments PR rows, the banner,link-buttonandmarkdown. Docs site adds "GitHub pull requests" setup guide.