Repository navigation
fix: show next diff from its top after marking a file reviewed - #123
Merged
Merged
Conversation
flexdinesh
marked this pull request as ready for review
October 27, 2026 04:33
flexdinesh
enabled auto-merge (squash)
October 27, 2026 04:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marking a file reviewed while scrolled partway into it collapsed the file but left the scroll offset unchanged, so the next diff opened mid-file. Pierre's scroll anchoring only corrects this when the next file's header is already visible, so files taller than the viewport hit it.
DiffWorkspace.tsx: when a file scrolled past its top is marked reviewed, scroll its collapsed header to the viewport top so the next diff starts from its first line. Skipped when hiding reviewed files (navigation already hands off to the neighbor) and when unmarking.use-reviewed-files.ts:toggleReviewedresolves whether the toggle was applied, so failed or stale writes don't scroll.DESIGN.md: document the behavior.app.spec.ts: browser test for marking a file reviewed mid-scroll; fails before the fix.Validation
mise run check: passed (133 browser tests, Go, contracts, static checks).