Repository navigation
feat: explicit worktree scanning and adaptive Reviews column - #124
Merged
Merged
Conversation
- `diffx` and `diffx <checkout>` collect only that checkout; `--scan-worktrees` adds its repo's worktrees - `--path` and non-checkout dirs keep scanning by default; `--scan-depth` with a checkout path errors - bootstrap `input` gains `checkout`; Sync reads "Sync checkout" for it - local mode shows the Reviews column only once 2+ current streams exist, then keeps it - repoint Impeccable diff workspace brief to `src/DiffWorkspace.tsx`
flexdinesh
marked this pull request as ready for review
October 27, 2026 07:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmd/diffxscope resolution (checkoutSelection): barediffxor one positional path inside a checkout now collects only that checkout;--scan-worktreesadds the repo's other registered worktrees.--path(any count) and non-checkout directories keep scanning by default.--scan-depthwith a checkout path errors since there is no directory search to bound. Makes worktree scanning explicit where the user pointed at one checkout.collector.Workspaces{Paths, Depth, LinkedWorktrees}: replaces the positionalpaths, depthargs ofCollectWorkspaces/DiscoverWorkspaces; withLinkedWorktrees=falsea repository contributes only the checkout containing its input. Sync reruns the same selection.serverapp.Selectiontravelslocalserver.Input->Collections->Capabilities.Input();inputenum gainscheckout(OpenAPI, generated types,readBootstrap).shell-policy.tsgainsreviewColumn(alwaysremote,multiplelocal) andcollection; the hook moves touse-shell-policy.tsso the policy stays node-testable.SessionProviderexposes a stickyreviewColumnflag: local mode shows the Reviews column, rail and compact drawer toggle oncestreamCountreaches 2, then keeps it for the page session. Search, comboboxes and sync stay. Sync reads "Sync checkout" for a single checkout.system.md,architecture.md,development.md,DESIGN.md,PRODUCT.md, user docs (usage.md,reviewing-changes.md). Impeccable diff workspace brief repointed tosrc/DiffWorkspace.tsx(was orphaned by a repo-root-relative path).diffxinside a repo no longer collects sibling worktrees; use--scan-worktrees.mise run check:push(pre-push hook: full suites, race tests, generated drift) passes on the rebased branch.