You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: prevent Enter from submitting MUI forms using uicore MuiForm - #1145
No actionable comments were generated in the recent review.
Walkthrough
The openstack-uicore-foundation dependency changes to 5.0.72-beta.1. Components and pages replace MUI Box form wrappers with MuiForm. Most Formik handlers and form attributes remain. RefundForm tests now submit by clicking the button and check that Enter does not submit.
Changes: MuiForm migration
Layer / File(s)
Summary
Replace Box form wrappers package.json, src/components/filters/*, src/components/forms/*, src/components/mui/*, src/pages/*
The foundation dependency changes to 5.0.72-beta.1. Forms across components and pages use MuiForm in place of Box-based wrappers. Existing Formik handlers and form attributes are retained in most forms. SaveViewDialog removes its explicit submit handler. RefundForm tests switch to button clicks, add a check that Enter does not submit, and retain success and failure assertions.
fntechgit/summit-admin#1072: This PR converts the email-flow event page to a Formik-based component, and this change updates the form wrapper in that same page.
Suggested reviewers:tomrndom, smarcet, ako3131
Merge Risk: Minimal · up to 11087
This change stops Enter from submitting forms by switching them to the shared form wrapper, and it updates tests to match the row-actions menus. No concrete defects remain after review, so it looks ready to merge.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the main change: a fix that stops Enter from submitting MUI forms by switching the form wrapper to the uicore MuiForm component. The raw summary shows many forms moved from a MUI Box c…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: a fix that stops Enter from submitting MUI forms by switching the form wrapper to the uicore MuiForm component. The raw summary shows many forms moved from a MUI Box configured as a form to MuiForm, and the RefundForm test and comment changes match the Enter-key behavior named in the title. The title is short, specific, and uses a conventional commit prefix.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Essentials
Run ID: 62d9bb8f-c4ac-46d4-8390-0bc92d9b48fc
Commits
Reviewing files that changed from the base of the PR and between dfe270c and 110876f.
Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Enter-key handling across 41 migrated forms depends on an unavailable beta dependency, requiring human browser validation of multiline editing, autocomplete selection, and mouse and keyboard activation of Save.
No open issues 🎉
What changed in this PR
This PR adopts the shared uicore MuiForm across admin forms to prevent accidental submission when Enter is pressed in an input.
Changes:
Updates openstack-uicore-foundation to 5.0.72-beta.1.
Replaces MUI Box form wrappers with MuiForm, retaining existing fields and form settings.
Updates refund tests to check Enter suppression and click-based submission.
The reason will be displayed to describe this comment to others. Learn more.
@santipalenque The MuiForm convention introduced here is not recorded in the form-patterns rule, so new forms will keep being written without it.
.claude/rules/summit-admin-form-patterns.md ("Modern: Formik + MUI") still shows Formik's <Form> as the template for new forms and does not mention MuiForm. After this PR no form in src uses <Form>, and every MUI form is expected to go through MuiForm, but nothing tells the next author that. A form written from the documented template submits on Enter again.
Suggested fix: update the modern example in that rule to the pattern this PR applies:
The reason will be displayed to describe this comment to others. Learn more.
Two blockers, both from the uicore bump to 5.0.74. Details inline.
Jest is red: 12 tests in 4 suites fail because 5.0.74 moves row Edit/Delete into an actions menu.
The editable cart total row is one cell too wide, for the same reason.
The earlier reviews were against 2322071 on 5.0.72-beta.1, so none of them saw the bump. I rechecked their points at dfe270c:
Badge feature form still submitting on Enter (smarcet): fixed. edit-badge-feature-page.js:104 uses MuiForm now, and there is no component="form" left in src.
Form-patterns rule doesn't mention MuiForm (smarcet): still open. .claude is gitignored here (.gitignore:15), so that rule file can't ship in this PR. It has to be updated where the rule is maintained.
Save-view dialog missing the native submit handler (CodeRabbit): fixed. save-view-dialog/index.js:66 has onSubmit={formik.handleSubmit} again.
IME composition (CodeRabbit): still there. MuiForm in 5.0.74 has no isComposing check. That's a uicore fix, not a summit-admin one, and I haven't tested it in a browser.
One more thing: the bump changes every table with onEdit/onDelete from one-click icons to a menu, app wide. Worth a line in the PR description so reviewers know to test it.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
caseylocker
left a comment
ref: https://app.clickup.com/t/9014802374/86bcwj81y
Summary by CodeRabbit
Summary