Repository navigation
[#50] Add strategy, hld and lld skills with a document reviewer - #53
Merged
Merged
Conversation
Three skills write a tech strategy, a high level design and a low level design, each from the document above it, with a document-reviewer agent reading every draft before the author sees it. Also: free checks for skill names and YAML frontmatter, and the workflow eval target now grants Bash so the bugfix and pr skills load there. Closes #50 Closes #52 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The plugin starts at
start-task, which sizes one change. There is nothing above it: a year's direction, the systems it needs and the components inside them are planned in whatever document someone opens, with no fixed shape, no fixed place and no review of whether the sections make sense against each other or against the plan above. One tech strategy leads to one or more high level designs, each to one or more low level designs, and each of those to around a dozenstart-tasktasks.Closes #50
Closes #52
What
Three new skills write a tech strategy, a high level design (HLD) and a low level design (LLD), each from the document above it, into a tree under
.freethinking/strategies/and.freethinking/designs/<strategy>/<hld>/. A newdocument-revieweragent reads every draft against its template and its parent before the author sees it. The workflow rule's eval target now lets thebugfixandprskills load, which they silently could not.Changes
strategy,hldandlldskills: each reads its parent first (earlier strategies, the strategy, or the HLD and the code), asks one round in prose, writes from its template, has the reviewer read the draft for at most two rounds, shows the path with open findings first and asks Approved or Changes needed, then hands off to the next level down. A figure is attributed to its source or carried to the author as a question. Each document needs its sections to make sense against each other and against the plan above..freethinking/<skill>/template.md.document-revieweragent (Read, Glob, Grep only): judges every section against its template, its parent and the document's other sections, flags figures stated with no source, and returns Findings in the wave reviewer's shape.start-task's description gains one clause sending a strategy or a design to the new skills.namematches its folder (two skills shipped asname: hldmid-branch and nothing caught it), and every frontmatter block parses as YAML (an unquoted:made the harness skip two cases, and an unquoted#7silently truncatedopens-pr-with-ticket's expected outcome).evals/README.mdtells case authors to quote such values.binwrappers, andbug-routes-to-bugfixandpr-routes-to-pr-skillgain a scaffold and askill-loadsgrader: thebugfixandprskills rungh/gitwhile they load, and without Bash they never loaded in this target, sostates-symptomfailed and the pr case passed on the Skill call alone (Workflow rule evals pass while the bugfix and pr skills fail to load #52)..freethinking/specs/design-skills/.Testing
make validate: 26 tests and the three validators pass.Evals, three runs per case:
writes-strategymissed its approval option once in its first run of three; the rerun passed 3/3.writes-from-strategytimed out at 300 s once while applying a second review round's fixes; the three happy-path cases now carrytimeout_seconds: 600.writes-from-hldtrace confirmed the reviewer reads the plugin's template path and does a real review.Risk and rollout
Minor: beyond the new skills, the changes are tweaks and fixes,
start-task's description clause and the workflow eval target granting Bash.Notes for reviewers
holds. Left as is until real use.# comment, which YAML allows; such a value has to be quoted.start-taskto read an LLD's tasks is out of scope.🤖 Generated with Claude Code