Repository navigation
Trim trailing whitespace in docs/SWITCH_KERNELS.md - #153
Merged
Merged
Conversation
Four lines of the SWITCH kernels write-up (13, 14, 39 and 111) end in a single space. The trailing-whitespace hook rejects them, so the CI Pre-commit job fails on main and on every PR into main that does not fix them itself. The test-cpu job needs pre-commit, so the CPU tests are skipped on those PRs too. None of the four is a Markdown hard line break (that takes two spaces), so the rendered page is unchanged. Signed-off-by: AlonMalach <alonmalach@gmail.com>
AlonMalach
requested review from
antonpibm,
aviv1ron1,
freunda and
yairallouche
as code owners
October 25, 2026 11:54
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
aviv1ron1
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Strip the trailing whitespace from four lines of
docs/SWITCH_KERNELS.md(lines 13, 14, 39 and 111). Each ends in a single space. No other file changes.Why
This unblocks the Pre-commit check and the CPU tests for every PR into
main.trailing-whitespacehook rejects them, so Pre-commit has failed onmainitself since 7e72456 (CI run).pre-commit run --all-files, so every PR intomainhits this file, even one that never touches it. Withfail_fast: true, the hooks after it (ruff, SPDX headers, link validation, uv-lock) never run either.test-cpuhasneeds: pre-commit, so the CPU tests are skipped on those PRs. Skipped is not failed, so this is easy to miss.Rendering
None of the four lines is a Markdown hard line break, because that takes two trailing spaces. The rendered page is unchanged.
Testing
pre-commit run --all-filespasses end to end (all 14 hooks, uv-lock included) and modifies no files.trailing-whitespace) turnsmain's copy of the file into exactly this PR's version.