Skip to content

test(payment-term): cover payment_term on wallets and one-off invoices - #107

Draft
annvelents wants to merge 1 commit into
feat/payment-termsfrom
feat/payment-terms-wallets-one-off
Draft

annvelents wants to merge 1 commit into
feat/payment-termsfrom
feat/payment-terms-wallets-one-off

Conversation

@annvelents

Copy link
Copy Markdown
Contributor

Context

Follow-up to #106: the wallet and one-off invoice cases that were held back until the API shipped them (getlago/lago-api#6579, getlago/lago-api#6580, now merged).

Changes

  • tests/payment_term.test.ts: wallet create sends the structured payment_term, and a one-off invoice create sends it too. No source change: the types come from the OpenAPI spec.

Before this can go green

openapi/client.ts and openapi/webhooks.ts are generated from the published spec (swagger.getlago.com/openapi.yaml), which does not have PaymentTermObject yet. CI type-checks only once getlago/lago-openapi#716 and getlago/lago-openapi#718 are merged and published; the same holds for #106.

Checked locally with both files generated from the #718 bundle: deno test -A tests/payment_term.test.ts passes (12 tests), deno fmt --check and deno lint clean.

Related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant