Repository navigation
fix: respect disabled rate limit retries - #108
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
Welcome back, @pcbeingused333!It looks like we still need your FLA signature on file. Please sign it here: Once signed, this PR will be automatically updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respect
retryOnRateLimit: falsewhen handling HTTP 429 responses.The wrapper throws
LagoRateLimitErrorfor a 429 response, then catches that same error and continues the retry loop even when retries are disabled. Check the retry option in the catch path so the error propagates after the first request.Extend the existing no-retry test with a request counter asserting exactly one request. The existing
maxRetriestest continues to cover enabled retries.Testing: the rate limit test file reports 24 passed and 1 failed on main (four requests instead of one), then 25 passed with the fix. Deno format and lint checks pass for both changed files. Tests use
deno test --no-check tests/rate_limit.test.ts: the command without--no-checkfails with TS2339/TS7006 in the generated OpenAPI client under Deno 2.9.8.AI disclosure: This change and its tests were prepared with assistance from OpenAI Codex.