Repository navigation
fix: honor rate limit configuration in all custom actions - #439
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
Welcome back, @pcbeingused333!It looks like we still need your FLA signature on file. Please sign it here: Once signed, this PR will be automatically updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All custom actions across clients should honor the client's rate-limit retry configuration. Many actions omit it when calling the HTTP request helpers, which silently use the default policy instead: disabling retries still sends four requests on HTTP 429, custom retry limits are ignored, and observer callbacks are lost.
Forward
self.rate_limit_retry_configin every custom action that omits it, matching the shared CRUD methods and actions that already pass it. This includes events, invoices, customers, subscriptions, plans, wallets and their nested clients, and the remaining custom reporting and resource actions.Testing
python -m pytest tests -q: 738 passed. Against unchanged main, the same suite produces 217 failed and 521 passed. Parameterized tests exercise every corrected action with retries disabled, zero retries, and a custom retry budget; invoice tests also verify successful response callbacks. HTTP responses are mocked and retry sleeps are disabled.Submission checklist
fix/branch.Suggested label: bug.
This change was generated with assistance from OpenAI Codex.