Repository navigation
docs(agent-tracing): Normalize GenAI developer conventions - #19465
Closed
sentry-junior[bot] wants to merge 8 commits into
Closed
sentry-junior[bot] wants to merge 8 commits into
sentry-junior[bot] wants to merge 8 commits into
Conversation
Co-Authored-By: Ognjen Bostjancic <ognjen.bostjancic@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 of 6 tasks
…ic/tet-2938-normalize-genai-developer-conventions
…developer-conventions
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4285b1e. Configure here.
vgrozdanic
approved these changes
Sep 17, 2026
1 of 6 tasks
Contributor
Author
|
Closing as superseded. Everything in this PR has either landed or moved:
Thanks for the review, @vgrozdanic. #19830 keeps the same cleanup behavior you approved here. |
sfanahata
added a commit
that referenced
this pull request
Oct 8, 2026
## DESCRIBE YOUR PR `pnpm build` and `pnpm build:developer-docs` both write to `.next`. When a PR touches both `docs/**` and `develop-docs/**`, the 404 workflow runs both builds in one job and then starts one server. By then the developer docs build has overwritten the docs build, so only developer docs get checked for broken links. This change gives each changed site its own job and runner: - A `changes` job decides which sites changed. - One `Lint <site> for 404s` job runs per changed site, in parallel. Each job builds, starts the server, and runs the linter. The runner is thrown away when the job ends, so the server doesn't need to be stopped and nothing else shares port 3000. - A small `lint-404` job keeps the required check name. It passes when every changed site passes its lint, or when no site changed. Changes to this workflow or `scripts/lint-404s/**` now lint both sites, so edits to the workflow check themselves. An earlier version of this PR handled the shared build with a bash script that started and stopped the server between sites. Separate jobs remove the need for it. PRs that touch both sites also run the two builds in parallel instead of one after the other. Replaces #19465. That PR's other changes already landed in #19509 (AI Agents doc) and #19526 (cross-site link handling). ## IS YOUR CHANGE URGENT? - [ ] Urgent deadline (GA date, etc.): YYYY-MM-DD - [ ] Other deadline: YYYY-MM-DD - [x] No deadline: Not urgent, can wait up to 1 week+ ## PRE-MERGE CHECKLIST - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) <!-- junior-request-attribution:start --> via **shannon.anahata**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AD0BB8KQT6MU%3A1791324850.904489 --> -- [View Junior Session](https://junior-prod.sentry.dev/conversations/slack%3AD0BB8KQT6MU%3A1791324850.904489) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AD0BB8KQT6MU%3A1791324850.904489/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Shannon Anahata <shannon.anahata@sentry.io>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Moves the developer conventions portion of #19459 into a separate PR so the 404 workflow does not build both docs sites in the same job.
Normalizes current GenAI attribute names, clarifies message part shapes, and fixes cached and reasoning token subset references in the AI Agents module.
Part of TET-2938.
IS YOUR CHANGE URGENT?
PRE-MERGE CHECKLIST
via Ogi.
--
View Junior Session [Sentry]