feat(android-nav3): [Android Nav3 5] Make SentryNavEffect accessible to sample apps - #6137
0xadam-brown wants to merge 1 commit into
Conversation
Make SentryNavEffect and related APIs public so they can be called from the Nav3 sample app. For now, keep them marked as @ApiStatus.Internal until we publicly released + include a CHANGELOG entry.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 323c163. Configure here.
| @Composable | ||
| @Suppress("FunctionNaming") | ||
| internal fun <T : Any> SentryNavEffect( | ||
| public fun <T : Any> SentryNavEffect( |
There was a problem hiding this comment.
Contradictory public API status annotations
Low Severity
SentryNavEffect and its parameter types are annotated with both @ApiStatus.Experimental and @ApiStatus.Internal. Those markers conflict: Internal means the API is not for host apps, while Experimental means it is public but unstable. The PR presents this as the integration surface host apps will use.
Additional Locations (2)
Triggered by project rule: PR Review Guidelines for Cursor Bugbot
Reviewed by Cursor Bugbot for commit 323c163. Configure here.
There was a problem hiding this comment.
Not sure what our convention here is, and happy to conform as needed.
This PR is meant to make SentryNavEffect public exclusively for our sample apps; official publication will come later, accompanied by a CHANGELOG entry, etc., at which point these APIs will still be experimental.
📲 Install BuildsAndroid
|


PR Stack (Android Nav3)
📜 Description
Make
SentryNavEffectpublic so the Nav3 sample app can consume the API shape we intend to expose.Still marked as
@ApiStatus.Internaluntil we actually release + include a CHANGELOG.💡 Motivation and Context
The sample app should validate the actual API host apps will use. Keeping
SentryNavEffectinternal blocks that validation, so this PR exposes the effect as the next step in the Nav3 stack.
addresses: JAVA-274
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog