Skip to content

fix(cloudflare): Bind pass-through Queue producer methods to the binding - #24592

Open
JPeer264 wants to merge 1 commit into
developfrom
jp/cloudflare-queue-producer-metrics-binding
Open

JPeer264 wants to merge 1 commit into
developfrom
jp/cloudflare-queue-producer-metrics-binding

Conversation

@JPeer264

Copy link
Copy Markdown
Member

The Queue producer proxy only wraps send and sendBatch and returned every other property unbound. Native methods like metrics() then ran with the proxy as this, which workerd rejects with "Illegal invocation". Pass-through functions are now bound to the underlying binding, the same way the Durable Object namespace, storage and Workers AI proxies already do it.

The integration test calls metrics() in workerd, which reproduces the original error without the fix.

Fixes #24590

🤖 Generated with Claude Code

The Queue producer proxy returned methods other than send and sendBatch
unbound, so calling a native method like metrics() ran it with the proxy
as `this` and workerd threw "Illegal invocation".

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@JPeer264
JPeer264 added this pull request to stack #24594 September 22, 2026 14:22
@JPeer264

Copy link
Copy Markdown
Member Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit c0aa90b. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.16 kB - -
@sentry/browser - with treeshaking flags 27.42 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 27.33 kB - -
@sentry/browser (incl. Tracing) 50.62 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 50.64 kB - -
@sentry/browser (incl. Tracing, Profiling) 53.62 kB - -
@sentry/browser (incl. Tracing, Replay) 90.21 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 79.31 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 94.9 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 107.85 kB - -
@sentry/browser (incl. Feedback) 46.69 kB - -
@sentry/browser (incl. sendFeedback) 34.22 kB - -
@sentry/browser (incl. FeedbackAsync) 39.32 kB - -
@sentry/browser (incl. Metrics) 30.18 kB - -
@sentry/browser (incl. Logs) 30.43 kB - -
@sentry/browser (incl. Metrics & Logs) 31.09 kB - -
@sentry/react 30.91 kB - -
@sentry/react (incl. Tracing) 52.91 kB - -
@sentry/vue 36.41 kB - -
@sentry/vue (incl. Tracing) 52.9 kB - -
@sentry/svelte 29.18 kB - -
CDN Bundle 30.86 kB - -
CDN Bundle (incl. Tracing) 51.12 kB - -
CDN Bundle (incl. Logs, Metrics) 33.12 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 53.09 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 73.84 kB - -
CDN Bundle (incl. Tracing, Replay) 88.7 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 90.63 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 94.76 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 96.75 kB - -
CDN Bundle - uncompressed 91.25 kB - -
CDN Bundle (incl. Tracing) - uncompressed 152.53 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 97.82 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 158.48 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 227.39 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 272.26 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 278.2 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 285.96 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 291.89 kB - -
@sentry/nextjs (client) 55.24 kB - -
@sentry/sveltekit (client) 51.04 kB - -
@sentry/core/server 39.93 kB - -
@sentry/core/browser 13.63 kB - -
@sentry/node 133.38 kB +0.02% +19 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 82.15 kB - -
@sentry/node - without tracing 89.93 kB +0.03% +21 B 🔺
@sentry/node - without channel injection 112.16 kB +0.02% +22 B 🔺
@sentry/aws-serverless 98.2 kB +0.02% +18 B 🔺
@sentry/cloudflare (withSentry) - minified 205.1 kB +0.02% +37 B 🔺
@sentry/cloudflare (withSentry) 510.51 kB +0.02% +68 B 🔺

View base workflow run

@JPeer264
JPeer264 marked this pull request as ready for review September 22, 2026 16:52
@JPeer264
JPeer264 requested a review from a team as a code owner September 22, 2026 16:52
@JPeer264
JPeer264 requested review from andreiborza, isaacs and mydea and removed request for a team September 22, 2026 16:52

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@sentry/cloudflare: Queue#metrics() throws "Illegal invocation" on the instrumented env

2 participants